Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't log full props or JS code #1117

Merged
merged 1 commit into from
Jul 22, 2018
Merged

Don't log full props or JS code #1117

merged 1 commit into from
Jul 22, 2018

Conversation

justin808
Copy link
Member

@justin808 justin808 commented Jul 22, 2018 •
edited
Loading

Long props result in very long error messages. This change truncates
the props and code to 1,000 chars

This change is Reviewable

@justin808
Don't log full props or JS code
989f01b 
Long props result in very long error messages
@coveralls
Copy link

coveralls commented Jul 22, 2018 •
edited
Loading

Coverage Status

Coverage remained the same at ?% when pulling 989f01b on better-errors into ea9d87a on master.

@justin808 justin808 merged commit 177275a into master Jul 22, 2018
@justin808 justin808 deleted the better-errors branch July 22, 2018 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@justin808 @coveralls