Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Babel version to 7 #1141

Merged
merged 2 commits into from
Sep 13, 2018
Merged

Conversation

tricknotes
Copy link
Contributor

@tricknotes tricknotes commented Sep 12, 2018

This change has been suggested in #1140 .


This change is Reviewable

@tricknotes
Copy link
Contributor Author

Oops, some tests are failed :<
I'll check it later.

@coveralls
Copy link

coveralls commented Sep 12, 2018

Coverage Status

Coverage remained the same at ?% when pulling b3a75e1 on tricknotes:upgrade-to-babel-7 into e6e15c4 on shakacode:master.

@tricknotes tricknotes force-pushed the upgrade-to-babel-7 branch 3 times, most recently from 32a6366 to f0f8ed2 Compare September 12, 2018 16:14
@tricknotes tricknotes changed the title Upgrade Babel version to 7 [WIP] Upgrade Babel version to 7 Sep 12, 2018
@tricknotes tricknotes changed the title [WIP] Upgrade Babel version to 7 Upgrade Babel version to 7 Sep 12, 2018
Now we use `yarn.lock` instead.
@tricknotes
Copy link
Contributor Author

All tests are passed on Travis CI.

@justin808
Could you review this PR?

@justin808 justin808 merged commit dce1b20 into shakacode:master Sep 13, 2018
@justin808
Copy link
Member

Thank you @tricknotes! Merged. I'll release. I also invited you to https://shakacode.slack.com/

@tricknotes
Copy link
Contributor Author

Woot, great thanks!
Also thanks for your invitation! Now I joined ;)

@tricknotes tricknotes deleted the upgrade-to-babel-7 branch September 13, 2018 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants