Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TypeScript error #1377

Merged
merged 2 commits into from
Jul 26, 2021
Merged

Fix TypeScript error #1377

merged 2 commits into from
Jul 26, 2021

Commits on Jul 11, 2021

  1. Fix TypeScript error

    It fixes the following Typescript error:
    
    ```
    error TS2345: Argument of type '{ traceTurbolinks: true; turbo: boolean; }' is not assignable to parameter of type '{ traceTurbolinks: boolean; }'.
      Object literal may only specify known properties, and ''turbo'' does not exist in type '{ traceTurbolinks: boolean; }'.
    ```
    
    That happens on this code:
    
    ```ts
    ReactOnRails.setOptions({
      'traceTurbolinks': true,
      'turbo': true
    })
    ```
    
    Due to the fact that the `options` type is inferred by `DEFAULT_OPTIONS`.
    mdesantis committed Jul 11, 2021
    Configuration menu
    Copy the full SHA
    bf483ef View commit details
    Browse the repository at this point in the history

Commits on Jul 26, 2021

  1. Configuration menu
    Copy the full SHA
    2be65a3 View commit details
    Browse the repository at this point in the history