Resolve 14.1.1 incompatibility with eslint & make sure that spec/dummy is linted by eslint #1693
Conversation
WalkthroughThis pull request introduces a series of configuration and code modifications across multiple files in the project. The changes primarily focus on ESLint configurations, component prop type validations, and minor structural adjustments in React components. The updates enhance code quality, type safety, and project structure, with specific attention to linting rules, import statements, and component prop handling. Changes
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (8)
🚧 Files skipped from review as they are similar to previous changes (8)
⏰ Context from checks skipped due to timeout of 90000ms (5)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (4)
spec/dummy/client/app/startup/HelloWorldHooksContext.jsx (2)
Line range hint
9-23: Consider extracting Result component to a separate file.While the restructuring improves hooks usage, the inner
Resultcomponent could be moved to its own file to improve maintainability and reusability.
25-29: PropTypes should be moved with the Result component.If the
Resultcomponent is extracted, ensure the PropTypes validation moves with it.spec/dummy/client/app/startup/HelloWorldProps.jsx (1)
Line range hint
11-14: Consider simplifying the delayed value implementation.The current implementation using state and useEffect could be simplified since
delayedValueis only set once and never updated.- const [delayedValue, setDelayedValue] = useState(null); - - useEffect(() => { - setDelayedValue(props.modificationTarget); - }, []); + const delayedValue = React.useMemo(() => props.modificationTarget, []);.eslintrc (1)
49-50: Consider documenting the rationale for disabled rules.While disabling these rules might be necessary for your use case, it would be helpful to document why these specific rules are disabled:
- react/forbid-prop-types
- jsx-a11y/anchor-is-valid
- react/forbid-prop-types: 0 - jsx-a11y/anchor-is-valid: 0 + # Disabled because we use compound prop types in legacy components + react/forbid-prop-types: 0 + # Disabled because we handle anchor clicks via custom handlers + jsx-a11y/anchor-is-valid: 0
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
yarn.lockis excluded by!**/yarn.lock,!**/*.lock
📒 Files selected for processing (20)
.eslintignore(1 hunks).eslintrc(1 hunks)CHANGELOG.md(1 hunks)package.json(3 hunks)spec/dummy/babel.config.js(1 hunks)spec/dummy/client/.eslintignore(0 hunks)spec/dummy/client/.eslintrc(0 hunks)spec/dummy/client/app/components/RouterLayout.jsx(1 hunks)spec/dummy/client/app/packs/rescript-components.js(1 hunks)spec/dummy/client/app/packs/server-bundle.js(1 hunks)spec/dummy/client/app/startup/ContextFunctionReturnInvalidJSX.jsx(2 hunks)spec/dummy/client/app/startup/HelloTurboStream.jsx(1 hunks)spec/dummy/client/app/startup/HelloWorldHooks.jsx(2 hunks)spec/dummy/client/app/startup/HelloWorldHooksContext.jsx(2 hunks)spec/dummy/client/app/startup/HelloWorldProps.jsx(2 hunks)spec/dummy/client/app/startup/ImageExample.jsx(1 hunks)spec/dummy/client/app/startup/RouterApp.server.jsx(1 hunks)spec/dummy/config/webpack/commonWebpackConfig.js(2 hunks)spec/dummy/config/webpack/serverWebpackConfig.js(4 hunks)spec/dummy/config/webpack/webpack.config.js(1 hunks)
💤 Files with no reviewable changes (2)
- spec/dummy/client/.eslintignore
- spec/dummy/client/.eslintrc
✅ Files skipped from review due to trivial changes (4)
- spec/dummy/client/app/packs/server-bundle.js
- spec/dummy/client/app/startup/HelloTurboStream.jsx
- spec/dummy/client/app/startup/RouterApp.server.jsx
- spec/dummy/config/webpack/commonWebpackConfig.js
⏰ Context from checks skipped due to timeout of 90000ms (7)
- GitHub Check: build-dummy-app-webpack-test-bundles (newest)
- GitHub Check: examples (newest)
- GitHub Check: rspec-package-tests (newest)
- GitHub Check: examples (oldest)
- GitHub Check: build-dummy-app-webpack-test-bundles (oldest)
- GitHub Check: build
- GitHub Check: rspec-package-tests (oldest)
🔇 Additional comments (19)
spec/dummy/client/app/packs/rescript-components.js (1)
7-7: Verify all import statements for HelloWorldReScript component.The change from named export to default export requires updating all import statements from
import { HelloWorldReScript }toimport HelloWorldReScript.✅ Verification successful
Export change is compatible with existing imports ✅
All existing imports of
HelloWorldReScriptare already using the default import syntax, so no updates are required.🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Search for any remaining destructured imports of HelloWorldReScript rg "import \{ .*HelloWorldReScript.* \}" spec/dummy/Length of output: 54
Script:
#!/bin/bash # Search for any imports containing HelloWorldReScript echo "=== Searching for all HelloWorldReScript imports ===" rg "import.*HelloWorldReScript" -A 2 # Search for any usage of HelloWorldReScript in JSX/TSX files echo -e "\n=== Searching for HelloWorldReScript usage in components ===" rg "<HelloWorldReScript" -A 2Length of output: 857
spec/dummy/client/app/startup/HelloWorldHooks.jsx (1)
6-6: Address the TODO comment.The comment "TODO: make more like the HelloWorld.jsx" should be addressed or removed if no longer applicable.
Would you like me to help implement the changes to make this component more similar to HelloWorld.jsx?
spec/dummy/client/app/components/RouterLayout.jsx (1)
6-6: LGTM! Clean refactor removing unused children prop.The removal of the unused children prop and its PropTypes definition improves code clarity. The router implementation remains correct and follows React Router best practices.
spec/dummy/babel.config.js (2)
1-1: LGTM! Import path updated to follow ESLint conventions.The removal of the
.jsextension aligns with common ESLint import rules.
3-3: LGTM! Named function improves code clarity.Replacing the anonymous function with
createBabelConfigenhances debugging and stack traces.spec/dummy/client/app/startup/ContextFunctionReturnInvalidJSX.jsx (2)
15-19: LGTM! Added PropTypes validation.The addition of PropTypes improves type checking and aligns with ESLint best practices.
Line range hint
6-13: Verify if this incorrect implementation is intentional.The component's implementation takes two parameters but doesn't wrap them correctly as noted in the comments below. If this is meant to be a test case for invalid implementations, please add a comment at the top of the file explaining this purpose.
✅ Verification successful
Implementation is intentionally incorrect as a test case
The file contains explicit comments indicating this is an example of incorrect implementation:
- Top comment states: "Example of incorrectly taking two params and returning JSX"
- Detailed comments explain the correct implementation that would use a wrapped function
- Located in
spec/dummydirectory alongside other test cases🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Search for test files or documentation referencing this component rg -l "ContextFunctionReturnInvalidJSX" --type=testLength of output: 80
Script:
#!/bin/bash # Check the content of the file for comments echo "=== File content ===" cat spec/dummy/client/app/startup/ContextFunctionReturnInvalidJSX.jsx echo -e "\n=== Similar files in directory ===" ls -1 spec/dummy/client/app/startup/ echo -e "\n=== References in JS/JSX files ===" rg "ContextFunctionReturnInvalidJSX" -t js -t jsxLength of output: 2161
spec/dummy/client/app/startup/HelloWorldProps.jsx (1)
28-33: LGTM! Added comprehensive PropTypes validation.The addition of PropTypes for both
helloWorldDataandmodificationTargetimproves type safety.spec/dummy/client/app/startup/ImageExample.jsx (2)
7-10: LGTM! Import statements are now properly organized.The imports are now logically grouped and placed at the top of the file, improving code organization.
12-12: Good cleanup: Removed unused props parameter.Removing the unused
_propsparameter improves code clarity since the component doesn't use any props.spec/dummy/config/webpack/serverWebpackConfig.js (3)
31-33: LGTM! Properly documented ESLint rule exception.The ESLint disable comment is correctly scoped to the specific line where parameter reassignment is necessary.
Line range hint
72-81: LGTM! Well-structured CSS loader filtering logic.The code properly filters out mini-css-extract-plugin and style-loader while maintaining clear logic flow.
98-99: LGTM! Properly documented ESLint rule exception for SSR file handling.The ESLint disable comment is correctly scoped to the specific line where parameter reassignment is needed for SSR file handling.
.eslintignore (1)
4-10: LGTM! Well-structured ESLint ignore patterns.The changes properly:
- Remove the broad spec/dummy ignore to enable linting
- Add specific ignore patterns for build artifacts, vendor files, and generated code
- Maintain proper linting coverage while excluding appropriate files
This aligns well with the PR objective to ensure spec/dummy is linted by ESLint.
.eslintrc (2)
44-44: LGTM! Proper extension handling configuration.The import/extensions rule is properly configured to handle both JS and JSX files.
56-58: LGTM! Good configuration for module resolution.The changes:
- Add proper alias for Assets directory
- Include .jsx in the extensions list for proper module resolution
package.json (2)
30-30: LGTM: ESLint import resolver additionThe addition of
eslint-import-resolver-aliasis appropriate for resolving the ESLint compatibility issues mentioned in the PR objectives.
Line range hint
42-43: Verify React version compatibilityThe package.json specifies React version ^19.0.0, but React 19 has not been officially released yet. This could lead to compatibility issues.
CHANGELOG.md (1)
21-24: LGTM: Well-formatted changelog entryThe changelog entry is properly formatted, accurately describes the changes, and provides appropriate attribution to the contributor.
| const nameDomRef = useRef(null); | ||
|
|
||
| // eslint-disable-next-line no-unused-vars | ||
| const handleChange = () => { |
There was a problem hiding this comment.
Shouldn't this simply be removed instead?
There was a problem hiding this comment.
I suppose. None of the useState code is actually necessary for the current demo.
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (2)
.github/workflows/lint-js-and-ruby.yml (2)
48-48: Review Global Installation of yalc
The workflow now runssudo yarn global add yalc. Please double-check if usingsudois necessary in this GitHub Actions environment. If not required, consider removing it to reduce elevated privilege usage.
58-59: Review Dummy App Node Modules Installation
There is a newly added step that installs Node modules for the dummy app with the commandyarn install --no-progress --no-emoji. Note that later in the workflow (line 65) a similar installation is performed with the--ignore-scriptsflag. Please verify if both installations are required or if they can be consolidated to streamline the workflow.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/lint-js-and-ruby.yml(1 hunks)
🧰 Additional context used
🪛 actionlint (1.7.4)
.github/workflows/lint-js-and-ruby.yml
55-55: property "versions" is not defined in object type {}
(expression)
70-70: property "versions" is not defined in object type {}
(expression)
🔇 Additional comments (2)
.github/workflows/lint-js-and-ruby.yml (2)
49-50: Confirm yalc Publish Step
The newly added step to publish thereact-on-railspackage viayalcis clear. Ensure that this command reliably publishes the expected local package version for your development workflow.
56-57: Local Package Addition via yalc
The step to addreact-on-railsto the dummy app usingyalcappears correctly structured. Just ensure that the published package from the previous step is the intended version for local testing.
| - name: Save dummy app ruby gems to cache | ||
| uses: actions/cache@v4 | ||
| with: | ||
| path: spec/dummy/vendor/bundle | ||
| key: dummy-app-gem-cache-${{ hashFiles('react_on_rails.gemspec') }}-${{ hashFiles('Gemfile.development_dependencies') }}-${{ matrix.versions }} |
There was a problem hiding this comment.
Verify Cache Key Consistency for Dummy App Ruby Gems
Similar to the node modules cache key, the gem cache key also includes ${{ matrix.versions }}. Confirm that this variable is defined in your job’s matrix; otherwise, consider removing it. For example:
- key: dummy-app-gem-cache-${{ hashFiles('react_on_rails.gemspec') }}-${{ hashFiles('Gemfile.development_dependencies') }}-${{ matrix.versions }}
+ key: dummy-app-gem-cache-${{ hashFiles('react_on_rails.gemspec') }}-${{ hashFiles('Gemfile.development_dependencies') }}📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| - name: Save dummy app ruby gems to cache | |
| uses: actions/cache@v4 | |
| with: | |
| path: spec/dummy/vendor/bundle | |
| key: dummy-app-gem-cache-${{ hashFiles('react_on_rails.gemspec') }}-${{ hashFiles('Gemfile.development_dependencies') }}-${{ matrix.versions }} | |
| - name: Save dummy app ruby gems to cache | |
| uses: actions/cache@v4 | |
| with: | |
| path: spec/dummy/vendor/bundle | |
| key: dummy-app-gem-cache-${{ hashFiles('react_on_rails.gemspec') }}-${{ hashFiles('Gemfile.development_dependencies') }} |
🧰 Tools
🪛 actionlint (1.7.4)
70-70: property "versions" is not defined in object type {}
(expression)
| - name: Save spec/dummy/node_modules to cache | ||
| uses: actions/cache@v4 | ||
| with: | ||
| path: spec/dummy/node_modules | ||
| key: dummy-app-node-modules-cache-${{ hashFiles('spec/dummy/package.json') }}-${{ matrix.versions }} |
There was a problem hiding this comment.
Verify Cache Key Consistency for Dummy App Node Modules
The caching configuration uses a key ending with ${{ matrix.versions }}. Static analysis indicates that the versions property might not be defined within the job's matrix. Please verify that you intend to reference a matrix.versions variable. If it isn’t defined, you may consider removing it from the key to avoid unintended cache misses. For example:
- key: dummy-app-node-modules-cache-${{ hashFiles('spec/dummy/package.json') }}-${{ matrix.versions }}
+ key: dummy-app-node-modules-cache-${{ hashFiles('spec/dummy/package.json') }}📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| - name: Save spec/dummy/node_modules to cache | |
| uses: actions/cache@v4 | |
| with: | |
| path: spec/dummy/node_modules | |
| key: dummy-app-node-modules-cache-${{ hashFiles('spec/dummy/package.json') }}-${{ matrix.versions }} | |
| - name: Save spec/dummy/node_modules to cache | |
| uses: actions/cache@v4 | |
| with: | |
| path: spec/dummy/node_modules | |
| key: dummy-app-node-modules-cache-${{ hashFiles('spec/dummy/package.json') }} |
🧰 Tools
🪛 actionlint (1.7.4)
55-55: property "versions" is not defined in object type {}
(expression)
|
I completely removed the workflow and Github actions are still not running, so I'm not sure how to proceed. |
Judahmeek
force-pushed
the
judahmeek/eslint-spec-dummy
branch
from
6053cbb to
07e9e2b
Compare
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.eslintrc (1)
49-50: Consider documenting reasons for disabled ESLint rulesYou've disabled two ESLint rules (
react/forbid-prop-typesandjsx-a11y/anchor-is-valid) without any explanation. Adding comments explaining why these rules are disabled would improve maintainability and help future contributors understand the reasoning.- react/forbid-prop-types: 0 - jsx-a11y/anchor-is-valid: 0 + # Disabled to allow array/object prop types in legacy components + react/forbid-prop-types: 0 + # Disabled to allow anchor tags with onClick handlers in legacy components + jsx-a11y/anchor-is-valid: 0
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
yarn.lockis excluded by!**/yarn.lock,!**/*.lock
📒 Files selected for processing (21)
.eslintignore(1 hunks).eslintrc(1 hunks).github/workflows/lint-js-and-ruby.yml(1 hunks)CHANGELOG.md(1 hunks)package.json(3 hunks)spec/dummy/babel.config.js(1 hunks)spec/dummy/client/.eslintignore(0 hunks)spec/dummy/client/.eslintrc(0 hunks)spec/dummy/client/app/components/RouterLayout.jsx(1 hunks)spec/dummy/client/app/packs/rescript-components.js(1 hunks)spec/dummy/client/app/packs/server-bundle.js(1 hunks)spec/dummy/client/app/startup/ContextFunctionReturnInvalidJSX.jsx(2 hunks)spec/dummy/client/app/startup/HelloTurboStream.jsx(1 hunks)spec/dummy/client/app/startup/HelloWorldHooks.jsx(2 hunks)spec/dummy/client/app/startup/HelloWorldHooksContext.jsx(2 hunks)spec/dummy/client/app/startup/HelloWorldProps.jsx(2 hunks)spec/dummy/client/app/startup/ImageExample.jsx(1 hunks)spec/dummy/client/app/startup/RouterApp.server.jsx(1 hunks)spec/dummy/config/webpack/commonWebpackConfig.js(2 hunks)spec/dummy/config/webpack/serverWebpackConfig.js(4 hunks)spec/dummy/config/webpack/webpack.config.js(1 hunks)
💤 Files with no reviewable changes (2)
- spec/dummy/client/.eslintrc
- spec/dummy/client/.eslintignore
🚧 Files skipped from review as they are similar to previous changes (17)
- spec/dummy/client/app/packs/rescript-components.js
- spec/dummy/client/app/startup/RouterApp.server.jsx
- spec/dummy/config/webpack/commonWebpackConfig.js
- spec/dummy/babel.config.js
- spec/dummy/client/app/startup/HelloTurboStream.jsx
- package.json
- spec/dummy/client/app/startup/HelloWorldHooks.jsx
- spec/dummy/client/app/startup/ImageExample.jsx
- spec/dummy/config/webpack/serverWebpackConfig.js
- spec/dummy/client/app/components/RouterLayout.jsx
- spec/dummy/client/app/startup/HelloWorldProps.jsx
- spec/dummy/client/app/startup/ContextFunctionReturnInvalidJSX.jsx
- spec/dummy/config/webpack/webpack.config.js
- spec/dummy/client/app/startup/HelloWorldHooksContext.jsx
- .eslintignore
- CHANGELOG.md
- .github/workflows/lint-js-and-ruby.yml
🧰 Additional context used
🪛 ESLint
spec/dummy/client/app/packs/server-bundle.js
[error] 4-4: Missing file extension for "./../generated/server-bundle-generated"
(import/extensions)
⏰ Context from checks skipped due to timeout of 90000ms (5)
- GitHub Check: rspec-package-tests (newest)
- GitHub Check: build-dummy-app-webpack-test-bundles (newest)
- GitHub Check: build
- GitHub Check: rspec-package-tests (oldest)
- GitHub Check: build-dummy-app-webpack-test-bundles (oldest)
🔇 Additional comments (4)
spec/dummy/client/app/packs/server-bundle.js (1)
3-4:❌ Incorrect review comment
Consider adding file extension for improved code clarity
The import statement has been modified to remove the
.jsfile extension, but this generates an ESLint error. While many bundlers support extensionless imports, explicitly including file extensions can improve code clarity and maintain consistency with ESLint rules.
🏁 Script executed:
#!/bin/bash # Check if the referenced file exists with or without extension echo "Checking if target file exists..." if [ -f "spec/dummy/client/app/generated/server-bundle-generated.js" ]; then echo "File exists with .js extension" elif [ -f "spec/dummy/client/app/generated/server-bundle-generated" ]; then echo "File exists without extension" else echo "Neither file exists at the expected path" fi # Check ESLint configuration for import/extensions rule echo "Checking ESLint configuration..." grep -A 5 "import/extensions" .eslintrc || echo "import/extensions rule not found in .eslintrc"Length of output: 669
Action Required: Reassess Import and File Generation Process
- The verification indicates that the target file (
server-bundle-generated) is not found at the expected path (neither asserver-bundle-generated.jsnor without an extension).- The current ESLint configuration (
import/extensions) is set to enforce omission of file extensions for JavaScript files, which means adding a.jsextension would conflict with our established rules.- Please verify that the file is being correctly generated by the
react_on_rails:generate_packsrake task. If the file is intended to exist, ensure its generation aligns with the import path; otherwise, consider adjusting the ESLint configuration if an extension is actually required.Likely an incorrect or invalid review comment.
🧰 Tools
🪛 ESLint
[error] 4-4: Missing file extension for "./../generated/server-bundle-generated"
(import/extensions)
.eslintrc (3)
44-44: Fix extension configuration in import/extensions ruleThe
" "key in the extensions configuration appears to be a typo or placeholder. Consider replacing it with"tsx"which would be more appropriate for a TypeScript project.
56-56: LGTM: Asset path alias added correctlyThe alias configuration for the "Assets" path looks good and will help simplify imports from the assets directory.
58-58: LGTM: JSX extension added to resolverAdding the
.jsxextension to the node resolver's extensions list is a good change that will ensure proper resolution of JSX files, which is essential for linting the spec/dummy directory correctly.
| spec/dummy/vendor | ||
| spec/dummy/tmp | ||
| spec/dummy/app/assets/config/manifest.js | ||
| spec/dummy/client/app/components/HelloWorldReScript.res.js |
There was a problem hiding this comment.
| spec/dummy/client/app/components/HelloWorldReScript.res.js | |
| **/*.res.js |
just in case we want to add more Rescript components later.
| alias: [ ["Assets", "./spec/dummy/client/app/assets"] ] | ||
| node: | ||
| extensions: [".js", ".ts", ".d.ts"] | ||
| extensions: [".js", ".jsx", ".ts", ".d.ts"] |
There was a problem hiding this comment.
| extensions: [".js", ".jsx", ".ts", ".d.ts"] | |
| extensions: [".js", ".jsx", ".ts", ".tsx", ".d.ts"] |
to avoid forgetting if we add TSX examples later.
| <%= link_to "Incorrectly wrapping a pure component in a function", pure_component_wrapped_in_function_path %> | ||
| </li> | ||
| <li> | ||
| <%= link_to "TurboStream Demo", turbo_frame_tag_hello_world_path %> |
There was a problem hiding this comment.
Is this something that should have been here before? Doesn't seem related to the other changes.
There was a problem hiding this comment.
Yes, this link should have been added earlier.
| @@ -1,5 +1,5 @@ | |||
| // import statement added by react_on_rails:generate_packs rake task | |||
| import './../generated/server-bundle-generated.js'; | |||
| import './../generated/server-bundle-generated.js'; // eslint-disable-line import/extensions | |||
There was a problem hiding this comment.
Should we update the task to generate it without extension instead? In a separate PR.
| const scssConfigIndex = baseClientWebpackConfig.module.rules.findIndex((config) => | ||
| '.scss'.match(config.test), | ||
| ); | ||
| ); // eslint-disable-next-line no-undef |
There was a problem hiding this comment.
| ); // eslint-disable-next-line no-undef | |
| ); | |
| // eslint-disable-next-line no-undef |
2 participants
Closes #1685
Summary
Remove this paragraph and provide a general description of the code changes in your pull
request... were there any bugs you had fixed? If so, mention them. If
these bugs have open GitHub issues, be sure to tag them here as well,
to keep the conversation linked together.
Pull Request checklist
Remove this line after checking all the items here. If the item is not applicable to the PR, both check it out and wrap it by
~.Add the CHANGELOG entry at the top of the file.
Other Information
Remove this paragraph and mention any other important and relevant information such as benchmarks.
This change is
Summary by CodeRabbit
Summary by CodeRabbit
Bug Fixes
spec/dummydirectory.Chores
Documentation
Refactor