Skip to content

Rename webpackConfig to serverClientOrBoth #1772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 10, 2025
Merged

Rename webpackConfig to serverClientOrBoth #1772

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/generators/react_on_rails/templates/base/base/config/webpack/development.js.tt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

const { devServer, inliningCss } = require('shakapacker');

const webpackConfig = require('./webpackConfig');
const generateWebpackConfigs = require('./generateWebpackConfigs');

const developmentEnvOnly = (clientWebpackConfig, _serverWebpackConfig) => {
// plugins
Expand All @@ -18,4 +18,4 @@ const developmentEnvOnly = (clientWebpackConfig, _serverWebpackConfig) => {
}
};

module.exports = webpackConfig(developmentEnvOnly);
module.exports = generateWebpackConfigs(developmentEnvOnly);
0 ...e/base/config/webpack/webpackConfig.js.tt → ...nfig/webpack/generateWebpackConfigs.js.tt
View file
Open in desktop
File renamed without changes.
4 changes: 2 additions & 2 deletions lib/generators/react_on_rails/templates/base/base/config/webpack/production.js.tt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
<%= add_documentation_reference(config[:message], "// https://github.com/shakacode/react_on_rails_demo_ssr_hmr/blob/master/config/webpack/production.js") %>

const webpackConfig = require('./webpackConfig');
const generateWebpackConfigs = require('./generateWebpackConfigs');

const productionEnvOnly = (_clientWebpackConfig, _serverWebpackConfig) => {
// place any code here that is for production only
};

module.exports = webpackConfig(productionEnvOnly);
module.exports = generateWebpackConfigs(productionEnvOnly);
4 changes: 2 additions & 2 deletions lib/generators/react_on_rails/templates/base/base/config/webpack/test.js.tt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
<%= add_documentation_reference(config[:message], "// https://github.com/shakacode/react_on_rails_demo_ssr_hmr/blob/master/config/webpack/test.js") %>

const webpackConfig = require('./webpackConfig')
const generateWebpackConfigs = require('./generateWebpackConfigs')

const testOnly = (_clientWebpackConfig, _serverWebpackConfig) => {
// place any code here that is for test only
}

module.exports = webpackConfig(testOnly)
module.exports = generateWebpackConfigs(testOnly)
Loading