Skip to content

RBS: Narrow type signatures for props parameters #1966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 13, 2025
Merged

RBS: Narrow type signatures for props parameters #1966

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sig/react_on_rails/controller.rbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ module ReactOnRails

def redux_store: (
String store_name,
?props: untyped,
?props: Hash[Symbol, untyped] | String,
?immediate_hydration: bool
) -> void

Expand Down
4 changes: 2 additions & 2 deletions sig/react_on_rails/helper.rbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ module ReactOnRails
# Returns html_safe string (ActiveSupport::SafeBuffer)
def redux_store: (
String store_name,
?Hash[Symbol, untyped] props
?Hash[Symbol, untyped] | String props
) -> safe_buffer

# Returns html_safe string (ActiveSupport::SafeBuffer)
Expand All @@ -33,7 +33,7 @@ module ReactOnRails
?Hash[Symbol, untyped] options
) -> safe_buffer

def sanitized_props_string: (untyped props) -> String
def sanitized_props_string: (Hash[Symbol, untyped] | String props) -> String

def rails_context: (
?server_side: bool
Expand Down