Fix no-turbolinks ci

.rubocop.yml

@@ -8,18 +8,21 @@ AllCops:
   Exclude:
     - 'vendor/**/*'
     - 'spec/fixtures/**/*'
-    - 'node_modules/**/*.*'
+    - 'node_modules/**/.*'
     - 'node_modules/**/*'
     - 'coverage/**/*'
     - 'db/**/*'
     - 'db/schema.rb'
     - 'db/seeds.rb'
     - 'client/node_modules/**/*.*'
-    - 'client/node_modules/**/*'
+    - 'client/node_modules/**/.*'
     - 'bin/**/*'
     - !ruby/regexp /old_and_unused\.rb$/
     - 'spec/react_on_rails/dummy-for-generators/**/*'
     - 'spec/dummy/bin/**/*'
+    - 'spec/dummy/client/node_modules/**/*'
+    - 'spec/dummy/client/node_modules/**/.*'
+    - 'gen-examples/examples/**/.*'
     - 'gen-examples/examples/**/*'
 
 Metrics/LineLength:

lib/react_on_rails/server_rendering_pool.rb

@@ -51,13 +51,13 @@ def self.server_render_js_with_console_logging(js_code)
     class << self
       private
 
-      def trace_messsage(js_code)
+      def trace_messsage(js_code, file_name = "tmp/server-generated.js")
         return unless ENV["TRACE_REACT_ON_RAILS"].present?
         # Set to anything to print generated code.
         puts "Z" * 80
         puts "react_renderer.rb: 92"
-        puts "wrote file tmp/server-generated.js"
-        File.write("tmp/server-generated.js", js_code)
+        puts "wrote file #{file_name}"
+        File.write(file_name, js_code)
         puts "Z" * 80
       end
 
@@ -75,9 +75,22 @@ def create_js_context
           bundle_js_code = File.read(server_js_file)
           base_js_code = <<-JS
 #{console_polyfill}
+#{execjs_timer_polyfills}
           #{bundle_js_code};
           JS
-          ExecJS.compile(base_js_code)
+          begin
+            ExecJS.compile(base_js_code)
+          rescue => e
+            file_name = "tmp/base_js_code.js"
+            msg = "ERROR when compiling base_js_code! See #{file_name} to "\
+              "ERROR when compiling base_js_code! See #{file_name} to "\
+              "correlate line numbers of error. Error is\n\n#{e.message}"\
+              "\n\n#{e.backtrace.join("\n")}"
+            puts msg
+            Rails.logger.error(msg)
+            trace_messsage(base_js_code, file_name)
+            raise e
+          end
         else
           if server_js_file.present?
             msg = "You specified server rendering JS file: #{server_js_file}, but it cannot be "\
@@ -90,6 +103,18 @@ def create_js_context
         end
       end
 
+      def execjs_timer_polyfills
+        <<-JS
+function setInterval() {
+ console.error('setInterval is not defined for execJS. See https://github.com/sstephenson/execjs#faq');
+}
+
+function setTimeout() {
+ console.error('setTimeout is not defined for execJS. See https://github.com/sstephenson/execjs#faq');
+}
+        JS
+      end
+
       # Reimplement console methods for replaying on the client
       def console_polyfill
         <<-JS

lib/react_on_rails/version.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module ReactOnRails
   VERSION = "2.2.0".freeze
 end

node_package/src/clientStartup.js

@@ -110,10 +110,10 @@ export default function clientStartup(context) {
     // Webpack bundles first.
 
     if (!turbolinksInstalled()) {
-      debugTurbolinks('WITHOUT TURBOLINKS: DOMContentLoaded handler installed.');
+      debugTurbolinks('NOT USING TURBOLINKS: DOMContentLoaded event, calling reactOnRailsPageLoaded');
       reactOnRailsPageLoaded();
     } else {
-      debugTurbolinks('WITH TURBOLINKS: document page:before-unload and page:change handlers' +
+      debugTurbolinks('USING TURBOLINKS: document page:before-unload and page:change handlers' +
         ' installed.');
       document.addEventListener('page:before-unload', reactOnRailsPageUnloaded);
       document.addEventListener('page:change', reactOnRailsPageLoaded);