Added errors if a null component is registered #273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
justin808
commented
Feb 14, 2016
justin808
commented
* Update CHANGELOG.md * rackt => reactjs for github * update nvm and ruby * Update dependencies
justin808
force-pushed
the
better-errors
branch
from
eca84d8
to
51a5360
Compare
|
@robwise There's an error with auto-rebuilding of the server rendering file: Repro:rake examples:gen_basic-server-rendering
cd gen-examples/examples/basic-server-rendering
rspecBut if you then run: |
|
@alexfedoseev Please review. |
|
@robwise Looks like it was a transient issue. |
|
Looks good! 👍 |
|
LGTM |
justin808
added a commit
that referenced
this pull request
Feb 14, 2016
Added errors if a null component is registered
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.