Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update StoreRegistry.js missing store error. #301

Merged
merged 1 commit into from
Mar 2, 2016

Conversation

justin808
Copy link
Member

Better registered errors when store cannot be found.

Review on Reviewable

@justin808 justin808 force-pushed the justin808-tweak-missing-store-message branch 2 times, most recently from 3742b42 to 2f6d662 Compare March 1, 2016 02:13
@justin808
Copy link
Member Author

@jbhatab or @thewoolleyman or @aaronvb or @robwise:

Give me the LGTM and I'll merge and create a new release.

@jbhatab
Copy link
Member

jbhatab commented Mar 1, 2016

is coveralls doing that weird stuff again?

looks good besides that.

@aaronvb
Copy link
Member

aaronvb commented Mar 1, 2016

👍

@justin808 justin808 force-pushed the justin808-tweak-missing-store-message branch 2 times, most recently from b088d1f to d9c72a4 Compare March 1, 2016 18:54
Better registered errors when store cannot be found.
@justin808 justin808 force-pushed the justin808-tweak-missing-store-message branch from d9c72a4 to 1b405d0 Compare March 1, 2016 20:10
justin808 added a commit that referenced this pull request Mar 2, 2016
…message

Update StoreRegistry.js missing store error.
@justin808 justin808 merged commit 7317b4a into master Mar 2, 2016
@justin808 justin808 deleted the justin808-tweak-missing-store-message branch March 2, 2016 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants