-
-
Notifications
You must be signed in to change notification settings - Fork 629
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove use of heroku-buildpack-multi #319
Conversation
I'm now noticing that the docs previously described that you could use |
@esauter5 This looks great! Can you find one other person in our slack room to confirm these instructions work? Thanks! |
When you run those CLI commands does the .buildpack file get updated? I have an existing .buildpack file with dependenices to heroku-buildpack-apt and heroku-bundle-config. |
AFAIK, the This brings an interesting point though. I guess I hadn't thought about the possibility that people still might need other buildpacks. May need to update the docs a little more to detail this option |
@esauter5 Keep me posted. |
@justin808 Will do. Hope to get to this in the next day or so. |
2b900a5
to
31a47ec
Compare
This should be good. I added something at the end of the heroku deployment section pointing to |
For more information, see [Using Multiple Buildpacks for an App](https://devcenter.heroku.com/articles/using-multiple-buildpacks-for-an-app) | ||
|
||
If for some reason you need custom buildpacks that are not officially supported by Heroku ([see this page](https://devcenter.heroku.com/articles/buildpacks)), we recommend checking out [heroku-buildpack-multi](https://github.com/ddollar/heroku-buildpack-multi). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is the one you want: https://github.com/heroku/heroku-buildpack-multi
This looks good. One suggestion added. |
The old docs recommended and linked to ddollar's version, but then used the heroku one in an example. The heroku version is just a fork of ddollar's and appears to be deprecated according to this comment. I tried using heroku's previously and was not able to get it to work. I'm open to linking to whichever though. |
@esauter5 Great catch! Yes, just last fall, the strategy changed. And the ddollar one has been more recently updated. |
@@ -10,8 +10,7 @@ class HerokuDeploymentGenerator < Rails::Generators::Base | |||
|
|||
def copy_heroku_deployment_files | |||
base_path = "heroku_deployment" | |||
%w(.buildpacks | |||
Procfile | |||
%w(Procfile |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we need to delete the .buildpacks file also.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahh good catch! That file was hiding from me because it was a dot file.
Let's:
Then I'll release the next version! Great job @esauter5! |
…ce heroku supports multiple buildpacks natively.
Thanks for the help @justin808! This should be good. |
💯 Reviewed 2 of 4 files at r1, 1 of 2 files at r2, 2 of 2 files at r3. Comments from the review on Reviewable.io |
Remove use of heroku-buildpack-multi
I was trying to use
heroku-buildpack-multi
and was getting failures when trying to push to Heroku. This led me to realize that Heroku natively supports using multiple build packs now, so there is no need to useheroku-buildpack-multi
or have to worry about a.buildpack
file. I simplified the instructions and removed references to.buildpack
in the code. Now, all you have to worry about is running this from the CLI: