Completes prior fix 366 for script sanitization #370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@alexfedoseev Take a quick peek at this one as well as #366. |
* Some cases missed, per: http://stackoverflow.com/a/23983448/1009332 * Added serverRendering and port to railsContext * Only logging attributes client side if tracing to avoid overwhelming server logs. On the client, one can optionally toggle expand the props. On the server, we stringified, and with a big set of props, that could be huge.
justin808
force-pushed
the
fix-sanitization-server-console-messages-2
branch
from
b65ea17
to
9539776
Compare
|
For example, one's code could conditionally log values if on the server, but not on the client. Basically, so long as the rendering comes out the same, React works. If you try to render the value of serverRendering, then React totally breaks. |
|
LGTM 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
server logs. On the client, one can optionally toggle expand the
props. On the server, we stringified, and with a big set of props,
that could be huge.
This change is