Pass-through JS error to client

[dzirtusss]

Pass-through simple version of #485

---

This change is

[dzirtusss]

@justin808 @robwise Please look - this is the most minimalist intrusion into error I can imagine. We just update the message and rethrow same error with all same parameters, incl. stacktrace

[coveralls]

Coverage remained the same at 82.36% when pulling 84824b1 on dzirtusss:js-exception2 into ea95759 on shakacode:master.

[justin808]

Looking good.

@robwise Take a look.

@samnang @robwise I don't see any worthwhile way to test this. I think we can skip a new test for this change.

---

Reviewed 1 of 1 files at r1, 2 of 2 files at r2.
Review status: all files reviewed at latest revision, 1 unresolved discussion.

---

node_package/src/handleError.js, line 38 [r1] (raw file):

}

export default (options) => {

const handleError = (option) => {
// blah blah
}

export default handleError;

---

Comments from Reviewable

[robwise]

I think this is a good compromise.

Also, if we are going to be modifying original error messages like this, we should tell the user who is doing it. So message should be like ReactOnRails encountered an error while rendering component: ${name}. Original message: ${e.message}

Or something

[justin808]

@dzirtusss Let's apply Rob's suggestion and call it good!

[dzirtusss]

Done. What about handleGeneratorFunctionIssue? Keep?

[justin808]

(Yes keep)

---

Reviewed 2 of 2 files at r3.
Review status: all files reviewed at latest revision, 1 unresolved discussion, some commit checks failed.

---

Comments from Reviewable

[justin808]

I'll merge once CI passes!

[coveralls]

Coverage remained the same at 82.36% when pulling 7d7dddb on dzirtusss:js-exception2 into ea95759 on shakacode:master.

[justin808]

@dzirtusss Can you please update the CHANGELOG.md.

[coveralls]

Coverage remained the same at 82.36% when pulling c98e25b on dzirtusss:js-exception2 into ea95759 on shakacode:master.

[squaresurf]

👏