Slight improvement to the 'no hydrated stores' error

[cookiefission]

Hi,

When I was trying to set up server side rendering, I ran into the 'no hydrated stores' error. After some digging, I realised I hadn't called redux_store_hydration_data anywhere in my view.

This should hopefully make it more clear that rendering redux_store_hydration_data is required.

Thanks

---

This change is 

[coveralls]

Coverage remained the same at 82.987% when pulling 14e8195 on cookiefission:improve/no-hydrated-stores-error into 447c4eb on shakacode:master.

[justin808]

Review status: 0 of 1 files reviewed at latest revision, 1 unresolved discussion.

---

node_package/src/StoreRegistry.js, line 46 at r1 (raw file):

        "redux_store near the top of your controller action's view (not the layout) " +
        'and before any call to react_component or you do not render ' +
        '`redux_store_hydration_data` anywhere on your page';

@cookiefission this is awesome. Can you try this out with a \n to clearly delineate the "ands" and the "or".

---

Comments from Reviewable

[cookiefission]

This is the error now. Is that what you were after?

[coveralls]

Coverage remained the same at 82.987% when pulling 3c0f9a2 on cookiefission:improve/no-hydrated-stores-error into 447c4eb on shakacode:master.

[justin808]

Please see my suggestion.

Try replacing and see if you like it.

---

Reviewed 1 of 1 files at r2.
Review status: all files reviewed at latest revision, 1 unresolved discussion.

---

node_package/src/StoreRegistry.js, line 46 at r1 (raw file):

Quoted 5 lines of code…

  const msg = 'There are no stores hydrated and you are requesting the store ' +
    `${name}. This can happen if you are server rendering and either \nyou do not call ` +
    "redux_store near the top of your controller action's view (not the layout) " +
    'and before any call to react_component \nor you do not render ' +
    'redux_store_hydration_data anywhere on your page';

  const msg = `There are no stores hydrated and you are requesting the store ${name}.

This can happen if you are server rendering and either:

1. You do not call redux_store near the top of your controller action's view (not the layout)
   and before any call to react_component.
2. You do not render redux_store_hydration_data anywhere on your page.`

---

Comments from Reviewable

[coveralls]

Coverage remained the same at 82.987% when pulling 1095759 on cookiefission:improve/no-hydrated-stores-error into 447c4eb on shakacode:master.

[justin808]

Review status: 0 of 1 files reviewed at latest revision, 1 unresolved discussion.

---

node_package/src/StoreRegistry.js, line 46 at r1 (raw file):

const msg = `There are no stores hydrated and you are requesting the store ${name}.

This can happen if you are server rendering and either:

1. You do not call redux_store near the top of your controller action's view (not the layout)
   and before any call to react_component.
2. You do not render redux_store_hydration_data anywhere on your page.`

Hey the formatting got skewered in my prior comment, @cookiefission

  const msg = 
`There are no stores hydrated and you are requesting the store ${name}.
This can happen if you are server rendering and either:
1. You do not call redux_store near the top of your controller action's view (not the layout)
and before any call to react_component.
2. You do not render redux_store_hydration_data anywhere on your page.`

Notice there are backticks around the whole string.
You can have embedded returns in the backtick strings.

---

Comments from Reviewable

[justin808]

I updated my comment. Please use backticks.

---

Review status: 0 of 1 files reviewed at latest revision, 1 unresolved discussion.

---

Comments from Reviewable

[justin808]

Reviewed 1 of 1 files at r3.
Review status: all files reviewed at latest revision, 1 unresolved discussion.

---

Comments from Reviewable

[coveralls]

Coverage remained the same at 82.987% when pulling 696043a on cookiefission:improve/no-hydrated-stores-error into 447c4eb on shakacode:master.

[justin808]

@cookiefission Did you try this out? You indented the lines, and the indents will be part of the message. I don't think you want the indents. Please paste a screenshot of how the message prints out.

[cookiefission]

This is how the error appears now. The 1. ... l goes on to another line because if I didn't do that, the line of code would go over 120 chars. I can change that if you want.

Also, when this is good to go, do you want me to squash the commits down or not?

[coveralls]

Coverage remained the same at 82.987% when pulling 50e8ee3 on cookiefission:improve/no-hydrated-stores-error into 447c4eb on shakacode:master.

[justin808]

Thanks @cookiefission!