Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve generator post-install help messages #631

Merged
merged 2 commits into from
Dec 1, 2016
Merged

Improve generator post-install help messages #631

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
de39abc
Improve generator post-install help messages
justin808 Dec 1, 2016
4093031
Update changelog
justin808 Dec 1, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,10 @@ Contributors: please follow the recommendations outlined at [keepachangelog.com]

## [Unreleased]

## [6.3.1]
##### Changed
- Improved generator post-install help messages. [#631](https://github.com/shakacode/react_on_rails/pull/631) by [justin808](https://github.com/justin808).

## [6.3.0]
##### Changed
- Modified register API to allow registration of renderers, allowing a user to manually render their app to the DOM. This allows for code splitting and deferred loading. [#581](https://github.com/shakacode/react_on_rails/pull/581) by [jtibbertsma](https://github.com/jtibbertsma).
Expand Down Expand Up @@ -393,7 +397,8 @@ Best done with Object destructing:
##### Fixed
- Fix several generator related issues.

[Unreleased]: https://github.com/shakacode/react_on_rails/compare/6.3.0...master
[Unreleased]: https://github.com/shakacode/react_on_rails/compare/6.3.1...master
[6.3.1]: https://github.com/shakacode/react_on_rails/compare/6.3.0...6.3.1
[6.3.0]: https://github.com/shakacode/react_on_rails/compare/6.2.1...6.3.0
[6.2.1]: https://github.com/shakacode/react_on_rails/compare/6.2.0...6.2.1
[6.2.0]: https://github.com/shakacode/react_on_rails/compare/6.1.2...6.2.0
Expand Down
10 changes: 6 additions & 4 deletions lib/generators/react_on_rails/base_generator.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,8 +117,10 @@ def append_to_spec_rails_helper
else
GeneratorMessages.add_info(
<<-MSG.strip_heredoc
Did not find spec/rails_helper.rb or spec/spec_helper.rb to add line
config.example_status_persistence_file_path = "spec/examples.txt"
Did not find spec/rails_helper.rb or spec/spec_helper.rb to add
# Ensure that if we are running js tests, we are using latest webpack assets
# This will use the defaults of :js and :server_rendering meta tags
ReactOnRails::TestHelper.configure_rspec_to_compile_assets(config)
MSG
)
end
Expand All @@ -141,9 +143,9 @@ def print_helpful_message

bundle && npm i

- Run the npm rails-server command to load the rails server.
- Run the foreman command to start the rails server and run webpack in watch mode.

npm run rails-server
foreman start -f Procfile.dev

- Visit http://localhost:3000/hello_world and see your React On Rails app running!
MSG
Expand Down