react_component outside of view #636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jtibbertsma can you include the fix with the test? CI needs to pass before we can merge. |
jtibbertsma
force-pushed
the
react-component-outside-of-view
branch
from
a06d5a7
to
785ebac
Compare
jtibbertsma
added a commit
to jtibbertsma/react_on_rails
that referenced
this pull request
Dec 6, 2016
The rails_context method previously assumed that the controller and request view helper methods were present. This commit checks that these methods are present before they're called. Resolves: shakacode#634
|
I'm not sure why CI failed. It seems to have failed during an npm install. |
|
|
|
@jtibbertsma Please create a changelog entry. Once tests pass, I'll create a release. |
The rails_context method previously assumed that the controller and request view helper methods were present. This commit checks that these methods are present before they're called. Resolves: shakacode#634
jtibbertsma
force-pushed
the
react-component-outside-of-view
branch
from
785ebac
to
3c5b519
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's a failing test case that demonstrates #634
This change is