-
-
Notifications
You must be signed in to change notification settings - Fork 630
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Add image handling example #768
WIP: Add image handling example #768
Conversation
Demonstrates using both background images in CSS and img tags. Path of images can be relative or absolute.
@cheremukhin23 Please be sure to check the Travis results:
https://travis-ci.org/shakacode/react_on_rails/jobs/213883336 |
61658bf
to
f4395b5
Compare
What caused this issue? Reviewed 22 of 22 files at r1, 1 of 1 files at r2, 1 of 2 files at r3, 1 of 1 files at r4. CHANGELOG.md, line 11 at r4 (raw file):
This doesn't match other CHANGELOG comments...FYI Comments from Reviewable |
@cheremukhin23 Can you try updating to 2.3.1, which is the webpack current. If that works, then let's merge. The change as it is now requires a release, so we should just move to the current version. |
@justin808 The issue is caused by breaking change in Webpack itself. I'll create a separate PR with webpack update and delete version change from this one. |
8443ec8
to
b720bfb
Compare
I've made webpack upgrade as a separate PR. So, I deleted last commits with webpack version lock and CHANGELOG.md. |
LGTM! |
This change is