Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Add image handling example #768

Merged
merged 3 commits into from
Mar 24, 2017

Conversation

cheremukhin23
Copy link
Contributor

@cheremukhin23 cheremukhin23 commented Mar 22, 2017

This change is Reviewable

@justin808
Copy link
Member

@cheremukhin23 Please be sure to check the Travis results:

-regenerator@^6.22.0Invalid configuration object. Webpack has been initialised using a configuration object that does not match the API schema.

https://travis-ci.org/shakacode/react_on_rails/jobs/213883336

@cheremukhin23 cheremukhin23 force-pushed the add-image-handling-example branch 3 times, most recently from 61658bf to f4395b5 Compare March 23, 2017 10:56
@justin808
Copy link
Member

4f7203b: Lock webpack version in generators to 2.2.1

What caused this issue?


Reviewed 22 of 22 files at r1, 1 of 1 files at r2, 1 of 2 files at r3, 1 of 1 files at r4.
Review status: all files reviewed at latest revision, 1 unresolved discussion.


CHANGELOG.md, line 11 at r4 (raw file):

## Fixed
- Locked Webpack version in generators to 2.2.1
- Added style-loaders to webpack config

This doesn't match other CHANGELOG comments...FYI


Comments from Reviewable

@justin808
Copy link
Member

@cheremukhin23 Can you try updating to 2.3.1, which is the webpack current. If that works, then let's merge. The change as it is now requires a release, so we should just move to the current version.

@cheremukhin23
Copy link
Contributor Author

@justin808 The issue is caused by breaking change in Webpack itself.
The output.path required to be an absolute path in webpack v2, but currently it is relative '../app/assets/webpack'.
In webpack 2.2.x there was no absolute path validation, but in 2.3.x it is added.

I'll create a separate PR with webpack update and delete version change from this one.

@cheremukhin23
Copy link
Contributor Author

cheremukhin23 commented Mar 24, 2017

I've made webpack upgrade as a separate PR. So, I deleted last commits with webpack version lock and CHANGELOG.md.
This PR is waiting for #771 now

@cheremukhin23 cheremukhin23 changed the title Add image handling example WIP: Add image handling example Mar 24, 2017
@justin808
Copy link
Member

LGTM!

@justin808 justin808 merged commit 9a56a93 into shakacode:master Mar 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants