-
-
Notifications
You must be signed in to change notification settings - Fork 630
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
i18n_yml_dir #777
i18n_yml_dir #777
Conversation
LocalesToJs uses all locales on rails i18n load path when generating js files, so all the locales from config/locales and in gems are included, using config.i18n_yml_dir option enables only locales from specified dir to be inluded in translations.js and default.js
@JasonYCHuang can you please review this one. |
@danijel Looks great. Couple small comments. Reviewed 8 of 8 files at r1. CHANGELOG.md, line 7 at r1 (raw file):
Please don't remove this placeholder. docs/basics/i18n.md, line 29 at r1 (raw file):
lib/generators/react_on_rails/templates/base/base/config/initializers/react_on_rails.rb.tt, line 70 at r1 (raw file):
Indicate what the default directory is. Comments from Reviewable |
@justin808 Thanks for quick review. |
tiny comment Reviewed 3 of 3 files at r2. CHANGELOG.md, line 8 at r2 (raw file):
Please format like the others. and blank line after placeholder. Comments from Reviewable |
@justin808 ok now? |
1 similar comment
one comment Reviewed 1 of 1 files at r3. CHANGELOG.md, line 10 at r3 (raw file):
missing the PR and author. See formatting of other entries. Comments from Reviewable |
@justin808 added |
1 similar comment
Review status: 7 of 8 files reviewed at latest revision, 6 unresolved discussions. CHANGELOG.md, line 10 at r4 (raw file):
period. :-) Comments from Reviewable |
Reviewed 1 of 1 files at r4. Comments from Reviewable |
@justin808 added, damn, what's wrong with me :-) |
The purpose of this PR is to add option to specify directory from where to load locale files for auto generating translations.js and default.js.
I have a rather big rails app and I don't want all the locales from rails i18n load path in my translations.js, for example I don't want rails_admin or kaminari, or other rails views stuff in there.
This change is