Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return markup hash form react component helper #800

Merged
merged 22 commits into from
Apr 13, 2017
Merged

Return markup hash form react component helper #800

merged 22 commits into from
Apr 13, 2017

Commits on Apr 13, 2017

  1. Allow to return object as a value of htmlResult from generator functi… 

    …on on the server

* Implement handling of Hash result of server_rendered_react_component_html in react_on_rails helper
* Implement additional example page for server rendered HTML that shows usage of htmlResult object
    @udovenko
    udovenko committed Apr 13, 2017
    Configuration menu
    Copy the full SHA
    a522653 View commit details
    Browse the repository at this point in the history

  2. Implement test for page title rendered in generator function on server 

    * Add conditional title to dummy app layout
* Implement rendering title string in generator function on server
* Add test for conditional title to integration_spec
* Refactor code in react_on_rails helper
    @udovenko
    udovenko committed Apr 13, 2017
    Configuration menu
    Copy the full SHA
    c410106 View commit details
    Browse the repository at this point in the history

  3. Add some notes to API doc

    @udovenko
    udovenko committed Apr 13, 2017
    Configuration menu
    Copy the full SHA
    6d49519 View commit details
    Browse the repository at this point in the history

  4. Implement example with ReactHelmet 

    * Now test page yields title rendered by ReactHelmet
* Add tests with disabled JS to integration spec to ensure correct title rendering on server
* Mark HTML strings other than component HTML (composed with props and console script) as html_safe
    @udovenko
    udovenko committed Apr 13, 2017
    Configuration menu
    Copy the full SHA
    2079156 View commit details
    Browse the repository at this point in the history

  5. Fix for dummy application title

    @udovenko
    udovenko committed Apr 13, 2017
    Configuration menu
    Copy the full SHA
    ba0b870 View commit details
    Browse the repository at this point in the history

  6. Pass params hash to #build_react_component_result_for_... methods

    @udovenko
    udovenko committed Apr 13, 2017
    Configuration menu
    Copy the full SHA
    e6f2d34 View commit details
    Browse the repository at this point in the history

  7. Now component key in renderedHtml object expected to match component … 

    …registration key
    @udovenko
    udovenko committed Apr 13, 2017
    Configuration menu
    Copy the full SHA
    f768529 View commit details
    Browse the repository at this point in the history

  8. Renamed example page and component registration 

    * Renamed example page to react_helmet
* Changed route to example page
* Renamed component registration to ReactHelmetApp
* Additional refactoring
    @udovenko
    udovenko committed Apr 13, 2017
    Configuration menu
    Copy the full SHA
    4c9bc3e View commit details
    Browse the repository at this point in the history

  9. Add docs and fix comments 

    * Create additional-reading/react-helmet.mb
* Fix comments for generator function
* Update javascript-api.md
    @udovenko
    udovenko committed Apr 13, 2017
    Configuration menu
    Copy the full SHA
    a6d8274 View commit details
    Browse the repository at this point in the history

  10. Update docs 

    * Update README.md
* Update CHANGELOG.md
    @udovenko
    udovenko committed Apr 13, 2017
    Configuration menu
    Copy the full SHA
    337b477 View commit details
    Browse the repository at this point in the history

  11. Small fixes for JS tests from previous PR

    @udovenko
    udovenko committed Apr 13, 2017
    Configuration menu
    Copy the full SHA
    f18cedb View commit details
    Browse the repository at this point in the history

  12. Updated CHANGELOG.md and README.md

    @udovenko
    udovenko committed Apr 13, 2017
    Configuration menu
    Copy the full SHA
    3c20d3a View commit details
    Browse the repository at this point in the history

  13. Assign params to local variables in #build_react_component_result_for… 

    …_... methods
    @udovenko
    udovenko committed Apr 13, 2017
    Configuration menu
    Copy the full SHA
    a81da5b View commit details
    Browse the repository at this point in the history

  14. Now rendered HTML for React component goes under the constant key com… 

    …ponentHtml

* Implement constant key usage in #build_react_component_result_for_server_rendered_hash method of react_on_rails helper
* Updated generator function for server rendering
* Additional refactoring
    @udovenko
    udovenko committed Apr 13, 2017
    Configuration menu
    Copy the full SHA
    ebfb6c7 View commit details
    Browse the repository at this point in the history

  15. Fixed react-helmet.md 

    * Fixed additional-reading/react-helmet.md
* Updated react_helmet.erb template accordingly
    @udovenko
    udovenko committed Apr 13, 2017
    Configuration menu
    Copy the full SHA
    010a28e View commit details
    Browse the repository at this point in the history

  16. Updated javascript-api.md

    @udovenko
    udovenko committed Apr 13, 2017
    Configuration menu
    Copy the full SHA
    362d8b8 View commit details
    Browse the repository at this point in the history

  17. Returnred rubocop back to gemfile

    @udovenko
    udovenko committed Apr 13, 2017
    Configuration menu
    Copy the full SHA
    9938bd5 View commit details
    Browse the repository at this point in the history

  18. Implement required params 

    * Implement required params for #build_react_component_result_for... methods
* Moved component_html_key to the constant
    @udovenko
    udovenko committed Apr 13, 2017
    Configuration menu
    Copy the full SHA
    f8a0069 View commit details
    Browse the repository at this point in the history

  19. Returned back checking for "componentHtml" key presence

    @udovenko
    udovenko committed Apr 13, 2017
    Configuration menu
    Copy the full SHA
    2eeb3f3 View commit details
    Browse the repository at this point in the history

  20. Updated CHANGELOG.md

    @udovenko
    udovenko committed Apr 13, 2017
    Configuration menu
    Copy the full SHA
    cdaccfb View commit details
    Browse the repository at this point in the history

  21. Fixed CHANGELOG.md

    @udovenko
    udovenko committed Apr 13, 2017
    Configuration menu
    Copy the full SHA
    dd1190d View commit details
    Browse the repository at this point in the history

  22. Update react-helmet 

    * Update react-helmet to v5.0.3 to resolve PropTypes warnings
* Fixed rubocop warnings
    @udovenko
    udovenko committed Apr 13, 2017
    Configuration menu
    Copy the full SHA
    301adb2 View commit details
    Browse the repository at this point in the history