Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix to handle nil values in json_safe_and_pretty #823

Merged
merged 2 commits into from
Apr 27, 2017
Merged

Fix to handle nil values in json_safe_and_pretty #823

merged 2 commits into from
Apr 27, 2017

Conversation

dzirtusss
Copy link
Contributor

@dzirtusss dzirtusss commented Apr 27, 2017 •
edited by justin808
Loading

This change is Reviewable

@dzirtusss dzirtusss force-pushed the sergey/fix-nil-values-in-pretty-json branch 3 times, most recently from ec884bf to 67e200b Compare April 27, 2017 07:54
@coveralls
Copy link

coveralls commented Apr 27, 2017 •
edited
Loading

Coverage Status

Coverage increased (+0.002%) to 98.022% when pulling 67e200b on sergey/fix-nil-values-in-pretty-json into 04e3b5f on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.002%) to 98.022% when pulling 67e200b on sergey/fix-nil-values-in-pretty-json into 04e3b5f on master.

@coveralls
Copy link

coveralls commented Apr 27, 2017 •
edited
Loading

Coverage Status

Coverage increased (+0.002%) to 98.022% when pulling 67e200b on sergey/fix-nil-values-in-pretty-json into 04e3b5f on master.

@coveralls
Copy link

coveralls commented Apr 27, 2017 •
edited
Loading

Coverage Status

Coverage increased (+0.002%) to 98.022% when pulling 67e200b on sergey/fix-nil-values-in-pretty-json into 04e3b5f on master.

justin808
justin808 reviewed Apr 27, 2017
View reviewed changes
app/helpers/react_on_rails_helper.rb
@@ -231,6 +231,7 @@ def server_render_js(js_expression, options = {})
end

def json_safe_and_pretty(hash_or_string)
return if hash_or_string.nil?
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we add a quick test?

@dzirtusss dzirtusss force-pushed the sergey/fix-nil-values-in-pretty-json branch from 67e200b to 2564691 Compare April 27, 2017 08:50
@coveralls
Copy link

Coverage Status

Coverage increased (+0.002%) to 98.022% when pulling 2564691 on sergey/fix-nil-values-in-pretty-json into 04e3b5f on master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+0.002%) to 98.022% when pulling 2564691 on sergey/fix-nil-values-in-pretty-json into 04e3b5f on master.

@justin808 justin808 merged commit 22fa5c4 into master Apr 27, 2017
@justin808 justin808 deleted the sergey/fix-nil-values-in-pretty-json branch April 27, 2017 09:23
@justin808
Copy link
Member

Great job @dzirtusss!

@coveralls
Copy link

Coverage Status

Coverage increased (+0.002%) to 98.022% when pulling 19738fa on sergey/fix-nil-values-in-pretty-json into 04e3b5f on master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+0.002%) to 98.022% when pulling 19738fa on sergey/fix-nil-values-in-pretty-json into 04e3b5f on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justin808 justin808 justin808 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dzirtusss @coveralls @justin808