Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix devBuild #877

Merged
merged 7 commits into from
Jul 1, 2017
Merged

fix devBuild #877

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
64ad8c3
fix devBuild
chenqingspring Jun 22, 2017
1d869ef
Merge branch 'master' into patch-1
chenqingspring Jun 30, 2017
19fb359
Set devBuild with configEnv
chenqingspring Jun 30, 2017
607a039
Update CHANGELOG.md about fixing devBuild
chenqingspring Jul 1, 2017
ca4cd8a
fix eslint & reformat CHANGELOG.md
chenqingspring Jul 1, 2017
bb20af0
add release number as 8.0.4
chenqingspring Jul 1, 2017
71bacd0
add reference diff link on 8.0.4
chenqingspring Jul 1, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,10 @@ Changes since last non-beta release.

*Please add entries here for your pull requests.*

## [8.0.4]
Copy link
Member

@justin808 justin808 Jul 1, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see the bottom of the file for how you do the diff of 8.04 and 8.03, @chenqingspring

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok. I didn't notice the references :(

but the build failed again..

### Fixed
- Fixed `devBuild` for webpack production build. [#877](https://github.com/shakacode/react_on_rails/pull/877) by [chenqingspring](https://github.com/chenqingspring)

## [8.0.3]
### Fixed
- Ruby 2.1 issue due to `<<~` as reported in [issue #870](https://github.com/shakacode/react_on_rails/issues/870). [#867](https://github.com/shakacode/react_on_rails/pull/867) by [justin808](https://github.com/justin808)
Expand Down
3 changes: 1 addition & 2 deletions webpackConfigLoader.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,8 +55,7 @@ const configLoader = (configPath) => {
const configEnv = (process.env.NODE_ENV || process.env.RAILS_ENV || 'development');
const ymlConfigPath = join(configPath, 'webpacker_lite.yml');
const configuration = safeLoad(readFileSync(ymlConfigPath, 'utf8'))[configEnv];

const devBuild = env !== 'production';
const devBuild = configEnv !== 'production';
const hotReloadingHost = configuration.hot_reloading_host || DEFAULT_HOT_RELOADING_HOST;

// NOTE: Rails path is hard coded to `/public`
Expand Down