Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle case of existing gitignore no newline end #916

Merged
merged 1 commit into from
Aug 17, 2017
Merged

Handle case of existing gitignore no newline end #916

merged 1 commit into from
Aug 17, 2017

Conversation

justin808
Copy link
Member

@justin808 justin808 commented Aug 16, 2017 •
edited
Loading

keep blank line at top in case existing .gitignore does not end in a
newline

If file ended with the coverage line below and no newline at the end, this got generated:

#lib genrerated from simplecov
coverage# React on Rails
npm-debug.log*
node_modules

This change is Reviewable

@justin808 justin808 force-pushed the fix-gitignore-append-generator branch from d50ba6b to d70f330 Compare August 17, 2017 06:37
@justin808
Handle case of existing gitignore no newline end
ec5da26 
keep blank line at top in case existing .gitignore does not end in a
newline
@justin808 justin808 force-pushed the fix-gitignore-append-generator branch from d70f330 to ec5da26 Compare August 17, 2017 07:07
@justin808 justin808 merged commit 01c5cfc into master Aug 17, 2017
@justin808 justin808 deleted the fix-gitignore-append-generator branch August 17, 2017 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@justin808