Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary dependencies from released NPM package #968

Merged
merged 4 commits into from
Nov 11, 2017
Merged

Remove unnecessary dependencies from released NPM package #968

merged 4 commits into from
Nov 11, 2017

Commits on Nov 10, 2017

  1. Run generator inside destination root 

    It is necessary to inform yarn what current directory should destination root.
    @tricknotes
    tricknotes committed Nov 10, 2017
    Configuration menu
    Copy the full SHA
    b9e5e0c View commit details
    Browse the repository at this point in the history

  2. Always generate package.json for generator spec 

    Without package.json in dummy app, yarn will search package.json in
ancestral directories.
And when running `yarn install <package-name>`, the package.json will
be destructively changed.
    @tricknotes
    tricknotes committed Nov 10, 2017
    Configuration menu
    Copy the full SHA
    1ed648c View commit details
    Browse the repository at this point in the history

  3. Remove unnecessary dependencies from released NPM package 

    These dependencies were injected by generator spec.
They are unnecessary for released react-on-rails package.
    @tricknotes
    tricknotes committed Nov 10, 2017
    Configuration menu
    Copy the full SHA
    7ccac2c View commit details
    Browse the repository at this point in the history

  4. Fix .eslintrc to resolve react-redux 

    react-on-rails no longer depends on react-redux.
The template file that uses react-redux should be passed ESLint
regardless its dependency.
    @tricknotes
    tricknotes committed Nov 10, 2017
    Configuration menu
    Copy the full SHA
    cb35cc4 View commit details
    Browse the repository at this point in the history