feat!: remove https option (#414)

CHANGELOG.md

@@ -14,6 +14,8 @@ Changes since the last non-beta release.
 
   The usage of those has been deprecated in Shakapacker v7 and now fully removed in v8. See the [v7 Upgrade Guide](./docs/v7_upgrade.md) for more information if you are still yet to address this deprecation.
 
+- Remove `https` option for `webpack-dev-server` [PR 414](https://github.com/shakacode/shakapacker/pull/414) by [G-Rath](https://github.com/g-rath).
+
 - Drop support for Ruby 2.6 [PR 415](https://github.com/shakacode/shakapacker/pull/415) by [G-Rath](https://github.com/g-rath).
 
 ## [v7.2.3] - March 23, 2024

lib/shakapacker/dev_server.rb

@@ -30,21 +30,6 @@ def port
     fetch(:port)
   end
 
-  def https?
-    value = fetch(:https)
-
-    unless value.nil?
-      puts "WARNING: `https: true` has been deprecated in favor of `server: 'https'`"
-    end
-
-    case value
-    when true, "true", Hash
-      true
-    else
-      false
-    end
-  end
-
   def server
     server_value = fetch(:server)
     server_type = server_value.is_a?(Hash) ? server_value[:type] : server_value
@@ -65,7 +50,7 @@ def server
   end
 
   def protocol
-    return "https" if server == "https" || https? == true
+    return "https" if server == "https"
 
     "http"
   end

spec/dummy/config/shakapacker.yml

@@ -22,7 +22,6 @@ development:
 
   # Reference: https://webpack.js.org/configuration/dev-server/
   dev_server:
-    https: false
     host: localhost
     port: 3035
     # Hot Module Replacement updates modules while the application is running without a full reload

spec/mounted_app/test/dummy/config/webpacker.yml

@@ -36,7 +36,6 @@ development:
 
   # Reference: https://webpack.js.org/configuration/dev-server/
   dev_server:
-    https: false
     host: localhost
     port: 3035
     public: localhost:3035

spec/shakapacker/dev_server_spec.rb

@@ -17,12 +17,6 @@
     end
   end
 
-  it "doesn't use https in development environment" do
-    with_rails_env("development") do
-      expect(Shakapacker.dev_server.https?).to be false
-    end
-  end
-
   it "uses http protocol in development environment" do
     with_rails_env("development") do
       expect(Shakapacker.dev_server.protocol).to eq "http"
@@ -48,7 +42,7 @@
   context "#protocol in development environment" do
     let(:dev_server) { Shakapacker.dev_server }
 
-    it "returns `http` by default (with unset `server` and `https`)" do
+    it "returns `http` by default (with unset `server`)" do
       with_rails_env("development") do
         expect(dev_server.protocol).to eq "http"
       end
@@ -61,15 +55,6 @@
         expect(dev_server.protocol).to eq "https"
       end
     end
-
-    it "returns `https` with unset `server` and `https` set to `true`" do
-      expect(dev_server).to receive(:server).and_return("http")
-      expect(dev_server).to receive(:https?).and_return(true)
-
-      with_rails_env("development") do
-        expect(dev_server.protocol).to eq "https"
-      end
-    end
   end
 
   context "#server in development environment" do

spec/shakapacker/shakapacker_spec.rb

@@ -8,7 +8,6 @@
       allow(dev_server).to receive(:host).and_return("localhost")
       allow(dev_server).to receive(:port).and_return("3035")
       allow(dev_server).to receive(:pretty?).and_return(false)
-      allow(dev_server).to receive(:https?).and_return(true)
       allow(dev_server).to receive(:running?).and_return(true)
     end
 

spec/shakapacker/test_app/config/shakapacker_css_extract_ignore_order_warnings.yml

@@ -45,7 +45,6 @@ development:
 
   # Reference: https://webpack.js.org/configuration/dev-server/
   dev_server:
-    https: false
     host: localhost
     port: 3035
     public: localhost:3035

spec/shakapacker/test_app/config/shakapacker_manifest_path.yml

@@ -41,7 +41,6 @@ development:
 
   # Reference: https://webpack.js.org/configuration/dev-server/
   dev_server:
-    https: false
     host: localhost
     port: 3035
     public: localhost:3035

spec/shakapacker/test_app/config/shakapacker_nested_entries.yml

@@ -44,7 +44,6 @@ development:
 
   # Reference: https://webpack.js.org/configuration/dev-server/
   dev_server:
-    https: false
     host: localhost
     port: 3035
     public: localhost:3035

spec/shakapacker/test_app/config/shakapacker_other_location.yml

@@ -38,7 +38,6 @@ development:
 
   # Reference: https://webpack.js.org/configuration/dev-server/
   dev_server:
-    https: false
     host: localhost
     port: 3035
     public: localhost:3035