Shakapacker v8: reintroduce https? predicate

[tagliala]

Desired behavior:

Allow Shakapacker::DevServer respond to https? predicate again, by checking if protcol == 'https'. This will also allow a tiny refactor:

shakapacker/lib/shakapacker/dev_server.rb

Line 53 in 295795e

return "https" if server == "https"

- return "https" if server == "https"
+ return "https" if https?

If you are interested in reintroducing this predicate, I can submit a PR.

Use case: jamesmartin/inline_svg#158

Actual behavior:

DevServer does not respond to https? predicate anymore

Setup environment:

• Ruby version: n/a
• Rails version: n/a
• Shakapacker version: 8.0

[G-Rath]

Why can't you use just check protocol? it's been there since v3 (seems like it could even be further back too).

Overall, I don't think it make sense to reintroduce this helper given how small it is and that the previous logic was deprecated upstream

[tagliala]

it's been there since v3

Thanks, I didn't check if it was available on legacy versions