pending v8 changes #410
pending v8 changes #410
Conversation
tomdracz
force-pushed
the
next
branch
3 times, most recently
from
ea1aad1
to
b8dc832
Compare
|
@tomdracz Is there any checklist or roadmap for v8? @ahangarha & I would like to know how we can best assist. |
|
I was thinking of that, but I think we're almost finished - #430 is the only remaining breaking change we definitely want to land; a potential outcome of #403 is a breaking change that could also be included but I don't think it's clear what the right path to actually take is and it doesn't seem critical given the lack of "+1s" so I don't think we need to get it resolved before releasing v8. Outside of that the only other questions to consider is what other versions do we want to drop support for - so far we've dropped support for Ruby v2.6 and Node v12. I don't know of any major pain or things being missed out on by supporting Ruby v2.7 and Node v14 besides just not being able to update some dependencies like Rubocop further meaning we're missing out on a few new rules that are nice to haves. (being on Ruby 3.1 would let us use shorthand hash properties which is nice, but I think v3.0 is still pretty new enough). |
|
No checklist/roadmap per se age mostly what outlined above by @G-Rath From my perspective we've got plenty of new things, deprecation and fixes to warrant next release. I'd quite like get all the PRS in flight over the line, though #403 as mentioned elsewhere seems to be need bit more. I'd also like #151 to be revisited so could be good to look at alongside existing PRs @Judahmeek @ahangarha |
|
@tomdracz @ahangarha FYI CI won't run until the merge conflict introduced by #449 is resolved |
|
@ahangarha I can't resolve the conflict because I'm not a member of this repository and you ideally need to push directly to the |
|
@G-Rath Surly I can do this. I need a green light 🟢 to ensure nobody relies on the current |
|
@ahangarha yup go for it - the only PR open against |
* ci: merge node related checks into a single workflow * ci: merge ruby related checks into a single workflow * ci: rename jobs
* ci: test against Ruby 3.1 and 3.2 * ci: test against Node 20
* Remove dependency on glob * Changelog
* Reference config from config rather than instance in compiler
…rule (#403) * Add config.includePaths and strip includePaths from file.js output paths * Update CHANGELOG.md * Refactor code to fix lint issue * Make sure to replace only once * Change variable name * Update README.md * Grammer change * Revert includePath change and make stripping additional_paths opt-in * Update CHANGELOG.md * Revert some more changes * Revert changes * Remove opt-in check * Update README and CHANGELOG
|
@ahangarha Can you create documentation similar to docs/v7_upgrade.md for the v8 upgrade? If not, let me know so that I can prioritize doing so. |
Upgrade guide draft started in #456 |
* V8 upgrade guide * docs: write v8 upgrade doc * docs: format with Prettier --------- Co-authored-by: Tom Dracz <tom.dracz@simplybusiness.co.uk>
* test: move into `test` directory * test: update import paths * test: update jest config * refactor: move test helpers * test: move jest config into dedicated file * docs: add changelog entry * chore: remove unneeded eslint ignore
I suggest not depending on @ahangarha unless he lets us know otherwise. |
|
Just to close the loop, I did the upgrade guide in #458 - so that's good to go. |
|
@tomdracz @justin808 unless you want to drop more versions of Node or Ruby, I think this major is good to go! Let me know if there's anything else I can do to help get it out the door 🙂 |
|
Should the beta release be after merging to main? |
Summary
Pending changes for v8
Pull Request checklist
Remove this line after checking all the items here. If the item does not apply to the PR, both check it out and wrap it by
~.Other Information
Remove this paragraph and mention other important and relevant information, such as benchmarks.