Strip CDN from manifest output

CHANGELOG.md

@@ -10,6 +10,11 @@ _next_ branch is for v8 changes
 ## [Unreleased]
 Changes since the last non-beta release.
 
+### Breaking changes
+- Removes CDN url from the manifest.json paths. [PR 473](https://github.com/shakacode/shakapacker/pull/473) by [tomdracz](https://github.com/tomdracz).
+
+  This returns to the Webpacker behaviour prior to the aborted Webpacker v6.
+
 ### Fixed
 
 - Fixes incorrect removal of files in the assets:clean task [PR 474](https://github.com/shakacode/shakapacker/pull/474) by [tomdracz](https://github.com/tomdracz).

package/environments/base.js

@@ -80,7 +80,7 @@ const getPlugins = () => {
       writeToDisk: true,
       output: config.manifestPath,
       entrypointsUseAssets: true,
-      publicPath: true
+      publicPath: config.publicPathWithoutCDN
     })
   ]
 

test/package/config.test.js

@@ -21,6 +21,13 @@ describe("Config", () => {
     expect(config.publicPath).toBe("http://foo.com/packs/")
   })
 
+  test("public path without CDN is not affected by the asset host", () => {
+    process.env.RAILS_ENV = "development"
+    process.env.SHAKAPACKER_ASSET_HOST = "http://foo.com/"
+    const config = require("../../package/config")
+    expect(config.publicPathWithoutCDN).toBe("/packs/")
+  })
+
   test("should return additional paths as listed in app config, with resolved paths", () => {
     const config = require("../../package/config")