Missing merge import in V8 upgrade docs
#489
Conversation
WalkthroughThe change involves updating the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
bensheldon
changed the title
merge export in V8 upgrade docsmerge import in V8 upgrade docs
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- docs/v8_upgrade.md (1 hunks)
Additional context used
LanguageTool
docs/v8_upgrade.md
[uncategorized] ~7-~7: Possible missing comma found.
Context: ...for Ruby 2.6 and Node v12 has also been dropped since they're very old at this point. ...
[style] ~7-~7: As an alternative to the over-used intensifier ‘very’, consider replacing this phrase.
Context: ...v12 has also been dropped since they're very old at this point. ## CDN host is stripped...
[uncategorized] ~12-~12: Use a comma before ‘and’ if it connects two independent clauses (unless they are closely connected and short).
Context: ...d. THis has been added in the aborted v6 and we've retained this in Shakapacker. Pr...
[style] ~19-~19: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...ferencing assets through view helpers. If your host might differ, between various...
[uncategorized] ~23-~23: Possible missing article found.
Context: ...void hardcording URLs in packs output. Second option has got a certain gotcha - dynam...
[uncategorized] ~36-~36: Possible missing comma found.
Context: ...ps://mycdn.url.com/packs'; ``` In your code and ensuring it is run first in the app...
[typographical] ~40-~40: After the expression ‘for example’ a comma is usually used.
Context: ...public-path/#automatic-publicpath. For example in yourwebpack.config.js: ``` const...
[uncategorized] ~54-~54: Use a comma before ‘although’ if it connects two independent clauses (unless they are closely connected and short).
Context: ...This will work in number of environments although some older browsers like IE will requir...
[grammar] ~71-~71: A verb may be missing after “it”. Please verify.
Context: ... with the recommended value to use, but it important the property is set to ensure all tooli...
[uncategorized] ~175-~175: Possible missing article found.
Context: ...ans going forward asset paths should be same regardless of their source: ```erb <%#...
Markdownlint
docs/v8_upgrade.md
21-21: null
Lists should be surrounded by blank lines
38-38: null
Bare URL used
32-32: null
Fenced code blocks should have a language specified
42-42: null
Fenced code blocks should have a language specified
Additional comments not posted (1)
docs/v8_upgrade.md (1)
155-155: Ensure the import statement includes bothgenerateWebpackConfigandmergeas documented.This change correctly addresses the issue of the missing
mergeexport in the documentation, as described in the PR. Good job on making the documentation more accurate and helpful.
|
Thank you! |
Summary
Simple documentation fix because I was seeing
ReferenceError: merge is not definedPull Request checklist
Summary by CodeRabbit
mergefunction fromshakapacker.