upgrade actions/setup-node to v4 #497
Conversation
WalkthroughThe recent updates primarily focus on enhancing compatibility and performance by upgrading GitHub Actions workflows to use the latest Node.js versions. Specifically, the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (3)
- .github/workflows/dummy.yml (1 hunks)
- .github/workflows/node.yml (1 hunks)
- CHANGELOG.md (1 hunks)
Files skipped from review due to trivial changes (2)
- .github/workflows/dummy.yml
- .github/workflows/node.yml
Additional context used
Markdownlint
CHANGELOG.md
13-13: Expected: h3; Actual: h4
Heading levels should only increment by one level at a time(MD001, heading-increment)
14-14: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
18-18: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
10-10: Expected: 1; Actual: 0; Above
Headings should be surrounded by blank lines(MD022, blanks-around-headings)
10-10: Expected: 1; Actual: 0; Below
Headings should be surrounded by blank lines(MD022, blanks-around-headings)
13-13: Expected: 1; Actual: 0; Below
Headings should be surrounded by blank lines(MD022, blanks-around-headings)
14-14: null
Lists should be surrounded by blank lines(MD032, blanks-around-lists)
Additional comments not posted (1)
CHANGELOG.md (1)
15-15: LGTM!The blank line is correctly placed.
CHANGELOG.md
Outdated
| @@ -10,6 +10,9 @@ _next_ branch is for v8 changes | |||
| ## [Unreleased] | |||
| Changes since the last non-beta release. | |||
|
|
|||
| #### Changed | |||
There was a problem hiding this comment.
Correct the heading level.
The heading level should be incremented by one level at a time. Change the h4 heading to h3.
- #### Changed
+ ### ChangedCommittable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| #### Changed | |
| ### Changed |
Tools
Markdownlint
13-13: Expected: h3; Actual: h4
Heading levels should only increment by one level at a time(MD001, heading-increment)
13-13: Expected: 1; Actual: 0; Below
Headings should be surrounded by blank lines(MD022, blanks-around-headings)
|
@adriangohjw can you check on the failing tests? |
|
@justin808 the failing specs seem to be an existing issue that happened in the previous commit too . Have opened a new issue for that #498 |
* fix: manually insert shakapacker using "echo" instead * manually overwrite "rack" to be v2
There was a problem hiding this comment.
Actionable comments posted: 1
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- CHANGELOG.md (1 hunks)
Additional context used
Markdownlint
CHANGELOG.md
14-14: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
18-18: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
Additional comments not posted (1)
CHANGELOG.md (1)
13-13: LGTM!The heading level increment is correct.
|
@adriangohjw latest merge to master is failing. Can you please fix? |
|
@justin808 i suspect this is a github runners issue (i face this in my work CI sometimes too) - possible to re-run the CI? 
|
Summary
Node.js 16 actions are deprecated and we want to update them to use the latest actions
actions/setup-node@v3toactions/setup-node@v4Pull Request checklist
- [ ] Add/update test to cover these changes- [ ] Update documentationSummary by CodeRabbit
Chores
actions/setup-node@v4for improved Node.js compatibility and support.Documentation
CHANGELOG.mdto reflect the changes in GitHub Actions, ensuring they use Node.js 20.0 for better compatibility.