Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better error messages and API tweaks #12

Merged
merged 3 commits into from
May 27, 2017
Merged

Better error messages and API tweaks #12

merged 3 commits into from
May 27, 2017

Conversation

justin808
Copy link
Member

@justin808 justin808 commented May 27, 2017

  • Added better error messages for missing files.
  • Added api to check if the manifest exists.

This change is Reviewable

* Added better error messages for missing files.
* Added api to check if the manifest exists.
@jonathanphilippou
Copy link

Made suggestions


Reviewed 8 of 8 files at r1.
Review status: all files reviewed at latest revision, 3 unresolved discussions.


README.md, line 144 at r1 (raw file):

The `asset_pack_path` helper provides the path of any given asset that's been compiled by webpack.
Note, this path is a subdirectory public.

Grammer


lib/webpacker_lite/configuration.rb, line 53 at r1 (raw file):

  private
    def load_data
      # binding.pry

remove


lib/webpacker_lite/manifest.rb, line 54 at r1 (raw file):

    def missing_manifest_file_error(path_object)
      # binding.pry

remove


Comments from Reviewable

@justin808
Copy link
Member Author

Review status: 5 of 8 files reviewed at latest revision, 3 unresolved discussions.


README.md, line 144 at r1 (raw file):

Previously, Conturbo (Jonathan Andrew Philippou) wrote…

Grammer

Done.


lib/webpacker_lite/configuration.rb, line 53 at r1 (raw file):

Previously, Conturbo (Jonathan Andrew Philippou) wrote…

remove

Done.


lib/webpacker_lite/manifest.rb, line 54 at r1 (raw file):

Previously, Conturbo (Jonathan Andrew Philippou) wrote…

remove

Done.


Comments from Reviewable

@jonathanphilippou
Copy link

:lgtm:


Reviewed 3 of 3 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@justin808 justin808 merged commit e0975f5 into master May 27, 2017
@justin808 justin808 deleted the better-errors branch May 27, 2017 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants