Updates for 2.0.3: Fix caching of manifest #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bug: React on Rails tests would load the manifest, then detect that we need to compile, and then WebpackerLite would fail to reload the manifest file. Either the old JS files would be used, or, if the test build script deletes the compiled files, then the test would fail from the named files being non-existent. Fix: The FileLoader tracks the mtime of any file loaded, and a call to load_instance will check that mtime if not in production. Other changes: * Tests improved. Expected and actual params were reversed. * Support for an env value to use the pry debugger.
justin808
force-pushed
the
fix-caching-of-loaded-files
branch
from
31dada7
to
c8bc621
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug: React on Rails tests would load the manifest, then detect that we
need to compile, and then WebpackerLite would fail to reload the
manifest file. Either the old JS files would be used, or, if the test
build script deletes the compiled files, then the test would fail from
the named files being non-existent.
Fix: The FileLoader tracks the mtime of any file loaded, and a call to
load_instance will check that mtime if not in production.
Other changes:
This change is