Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent race condition (fixes #134) #135

Merged
merged 1 commit into from
Jul 10, 2014
Merged

Conversation

callumlocke
Copy link
Contributor

this fixes it, I no longer get the uncaught ENOENT error I reported in #134

but I notice there's a lot more calls to fs.existsSync throughout the code... might be worth trying to remove them too, for the same reason stated in the issue

@shama
Copy link
Owner

shama commented Jul 10, 2014

Interesting, thanks for this! I'll work on updating the other instances of fs.exists and stop using that.

shama added a commit that referenced this pull request Jul 10, 2014
Prevent race condition (fixes #134)
@shama shama merged commit 34fa0d3 into shama:master Jul 10, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants