Adds Exclusion Support to Gaze. Fixes GH-7 #21
Conversation
Add test case for exclusions in Gaze. Testcase.. Fix test cases on this branch. Code Review mchoy. Ran local tests, 42 passes. Yay. Tested locally as well using my project, and it worked the way I expected it too. Yay! Minor fixes.
|
@shama should be good for review now, I went through and fixed all the things I saw after I took a second look today. I've got a version run through JSHint available if you want it. you can see it at... |
| if (this._patterns[i].indexOf('!') === 0) { | ||
| //First time a negation is hit, we can hop out of the forEach. | ||
| matched = false; | ||
| continue; |
There was a problem hiding this comment.
(Just reading this to try to help out in reviewing.. If you don't mind.)
Did you mean break here?
Alternatively, you can use the Array.some() method.
There was a problem hiding this comment.
Thanks for the hint on array.some, didn't know about it.
Yea, it should be a break. Oops :o
|
I really appreciate the work you put into this @jamie-stackhouse. Although I think we should upstream this functionality. I found this lib fileset which does exactly what we're trying to accomplish here. Just waiting for a merged PR to get published and will integrate. I have the integration started in the patterns branch. |
|
Thanks for the update, @shama, and I'll be integrating it to the incremental building plugin I'm working on! |
|
FWIW, I'm going to be extrapolating all of |
|
Hey, seeing as how the issue related to this pull request is going to be solved, I'mma close it. Thanks! |
|
Thanks again for pinpointing this issue Jamie! Fixed on 5578985. |
This is the same request as #20, just squashed into one commit. To make it easier to look at/maintain.
If both this and gruntjs/grunt-contrib-watch#43 are applied, gruntjs/grunt-contrib-watch#20 is fixed for me.