Wait until all listeners are removed before finishing test #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this change, running just the test/add_test.js tests, Node never exits. E.g.
./node_modules/grunt-contrib-nodeunit/node_modules/.bin/nodeunit test/add_test.js
This leaves the multi-watch tests as they were, but it makes the others consistent with regard to removing listeners.
|
Thanks for the PR, give me a bit to merge as I want to move this into v0.5 branch as well. Have a look at the v0.5 branch. That is where the active development is currently at. Which operating system and version of node are you running? Try |
|
Looks like it is no longer an issue with that particular test file on your v0.5 branch. I'm running Node 0.10 on OSX (same behavior with 0.11). Looks like the keep alive timer was doing its job. You can still reproduce it with the v0.5 branch and the watch_test.js script: Without Grunt globally installed, |
shama
pushed a commit
that referenced
this pull request
Mar 20, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this change, running just the test/add_test.js tests, Node never exits. E.g.
I'm trying to test some changes and having trouble getting the tests to run properly. I'm guessing there may be other similar problems, but this one was the clearest.