Make webpack-stream agnostic of the webpack version #188
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation of
webpack-stream
forces developers to use thewebpack
version defined in thepackage.json
.Realistically we can assume that this package will always be used in a context where its host have
webpack
as dependency. This is why we can leverage the npm peer dependencies.I added the package
install-peer-dependencies
so that we can run the unit tests even if the project is not embedded anywhere.I also decided not to add that to the
postinstall
npm hook because it is intended for development purposes only.Those change bring up another problems though. The unit tests are very version dependant and about 80% of them are failing if we try running this with webpack 4.
Not too sure what to do with those, I'd be happy to listen to your recommendation and update accordingly.