Add support for disabled extensions #836
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix auto upload! * Properly stop watching * Add synchronous functions * Move watcher to a new service * Make a new service for watcher * Add general ignored items setting for chokidar * Use globalCommons's autoUploadService instance * Reset * Add local settings to ignored files * Asynchronously get ignored items * Remove unused import * Use autoUploadService * Use the globalCommonService everywhere Since the autoUploadService is an instance in Commons, using a global Commons instance will allow everything to use the same instance. * Stop spamming with extension paths * Fix to work with async functions * Add global state to ignored files * Add .DS_Store and sync.lock * Start watcher only after downloading has finished * Inform user that auto upload has started
Execute vs code list extensions command line to get all extensions even the ones that are disabled. Iterate over enabled extensions and remove it from the disabled array.
|
Thank you for the PR. Also please open new PR , as in this PR other commits are also included. |
|
@shanalikhan sure, will do. I'm kind confused from where I should create my branch |
|
I think I got it now @shanalikhan , will close this one in favour of #838 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description of what this resolves:
Takes account disabled extensions when uploading or downloading the gist file.
Changes proposed in this pull request:
CreateExtensionListnow usescode --list-extensionsto get enabled and disabled extensions;downloadexecutes it verifies the extension object's enabled property . If false callscode --disable-extensionwith the extension name.Fixes: #143
How Has This Been Tested?
Tested on a Macbook with VSCode.
code-settings-syncproject;F5) inside this branch executeUpload / Update settings;Download settings;Checklist:
IssueHunt Summary
IssueHunt has been backed by the following sponsors. Become a sponsor