Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merging contribution from shpingalet007 to remove 'prefixOnly' #6

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

shanegenschaw
Copy link
Owner

Re-merging Khan#34 with contribution from shpingalet007 to remove the prefixOnly flag. See comment with explanation.

@shanegenschaw
Copy link
Owner Author

I'm thinking maybe this should be a major version bump (v3.0.0) since it is a breaking change for anyone who uses that flag (I do not).

Copy link
Collaborator

@shpingalet007 shpingalet007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. The only difference is that you don't use --minify flag for NCC, but it doesn't matter in sense of functionality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants