Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Grayson Gall <66559200+gsgall@users.noreply.github.com>
  • Loading branch information
csdechant and gsgall authored Nov 5, 2024
1 parent f9ee37f commit 1d4e1b4
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions doc/content/source/bcs/CircuitDirichletPotential.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@ V_\text{source} + V_\text{cathode} = e \Gamma A R
\end{equation}

Where $V_\text{source}$ is driven the potential, $V_\text{cathode}$ is the potential at cathode,
$\Gamma$ is the charged flux to the boundary, $e$ is the elemental charge, $A$ is the cross-sectional area of the plasma, and
$R$ is the ballast resistance. When converting the density to log form and applying a scaling factor for both the mesh and voltage,
$\Gamma$ is the charged particle flux at the boundary, $e$ is the elemental charge, $A$ is the cross-sectional area of the plasma, and
$R$ is the ballast resistance. When converting the density to log-molar form and applying a scaling factor for both the mesh and voltage,
`CircuitDirichletPotential` is defined as

\begin{equation}
Expand All @@ -24,7 +24,7 @@ V_\text{source} + V_\text{cathode} = e N_{A} \Gamma \frac{A}{l_{c}^2} \frac{R}{V
Where $N_{A}$ is Avogadro's number, $l_{c}$ is the scaling factor of the mesh, and $V_{c}$ is the scaling factor of the potential.


The charged flux is supplied as a [Postprocessor](syntax/Postprocessors/index.md) (usually the [`SideCurrent`](/postprocessors/SideCurrent.md) Postprocessor).
The charged particle flux is supplied as a [Postprocessor](syntax/Postprocessors/index.md) (usually the [`SideCurrent`](/postprocessors/SideCurrent.md) Postprocessor).

!alert warning title=Untested Class
The CircuitDirichletPotential does not have a formalized test, yet. For this reason,
Expand All @@ -48,7 +48,7 @@ please refer to the [MOOSE Contributing page](framework/contributing.md).
potential_units = V
resist = 100 #in Ohms
surface = anode
surfuce_potential = 100 #in V
surface_potential = 100 #in V
boundary = 'electrode'
[]
[]
Expand Down

0 comments on commit 1d4e1b4

Please sign in to comment.