Skip to content

Fix image references and increase leniency of the pod anti affinity rule #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 19, 2025
Merged

Fix image references and increase leniency of the pod anti affinity rule #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 11 additions & 9 deletions deploy/k8s/controller-deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,14 +25,16 @@ spec:
serviceAccountName: cloudstack-csi-controller
affinity:
podAntiAffinity:
requiredDuringSchedulingIgnoredDuringExecution:
- labelSelector:
matchExpressions:
- key: "app.kubernetes.io/name"
operator: In
values:
- cloudstack-csi-controller
topologyKey: "kubernetes.io/hostname"
preferredDuringSchedulingIgnoredDuringExecution:
- weight: 100
podAffinityTerm:
labelSelector:
matchExpressions:
- key: "app.kubernetes.io/name"
operator: In
values:
- cloudstack-csi-controller
topologyKey: "kubernetes.io/hostname"
nodeAffinity:
requiredDuringSchedulingIgnoredDuringExecution:
nodeSelectorTerms:
Expand All @@ -59,7 +61,7 @@ spec:

containers:
- name: cloudstack-csi-controller
image: cloudstack-csi-driver
image: ghcr.io/shapeblue/cloudstack-csi-driver:master
Copy link
Preview

Copilot AI Aug 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using the 'master' tag for container images is not recommended for production deployments as it can lead to unpredictable behavior when the master branch is updated. Consider using a specific version tag or commit SHA for reproducible deployments.

Suggested change
image: ghcr.io/shapeblue/cloudstack-csi-driver:master
image: ghcr.io/shapeblue/cloudstack-csi-driver:v1.2.3

Copilot uses AI. Check for mistakes.

imagePullPolicy: Always
args:
- "controller"
Expand Down
2 changes: 1 addition & 1 deletion deploy/k8s/node-daemonset.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ spec:

containers:
- name: cloudstack-csi-node
image: cloudstack-csi-driver
image: ghcr.io/shapeblue/cloudstack-csi-driver:master
Copy link
Preview

Copilot AI Aug 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using the 'master' tag for container images is not recommended for production deployments as it can lead to unpredictable behavior when the master branch is updated. Consider using a specific version tag or commit SHA for reproducible deployments.

Suggested change
image: ghcr.io/shapeblue/cloudstack-csi-driver:master
image: ghcr.io/shapeblue/cloudstack-csi-driver:v1.2.3

Copilot uses AI. Check for mistakes.

imagePullPolicy: IfNotPresent
args:
- "node"
Expand Down
Loading