Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make explicit Arrayfire use config files #140

Merged
merged 30 commits into from
Feb 19, 2020
Merged

Make explicit Arrayfire use config files #140

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
cda1ad2
Docs update for Linux
Oct 1, 2019
8f8a136
Fix memory leaks when getting host pointer from Arrayfire.
Feb 13, 2020
a4837ef
Fix Heap Corruption (0xC0000374) on Windows.
Feb 14, 2020
0546168
Fix docs
Feb 14, 2020
ae01eaa
Fix leak and minor improvements
Feb 14, 2020
f1e5507
Move privete headers to internal folder
Feb 14, 2020
87952e2
Add CMakeSettings for VS
Feb 14, 2020
49311e3
Fix compilation on Linux
Feb 14, 2020
6b904d4
Fix compilation
Feb 14, 2020
7068041
Fix compilation on Linux
Feb 14, 2020
162dd0c
lowercase cmake commands
Feb 15, 2020
2e28d70
Improve exception safety using smart pointers
Feb 15, 2020
f765293
Move private headers to internal folder
Feb 15, 2020
fbfae10
Improve const correctnes of Array class.
Feb 15, 2020
fc5e005
Improve readability
Feb 15, 2020
7b21a08
turn cmake commands lowercase
Feb 15, 2020
e9f8950
Add missing header
Feb 15, 2020
e41b277
Make Failing test verbose on Linux
Feb 15, 2020
7efa016
Update dependencies
Feb 17, 2020
3a28260
Fix CI
Feb 17, 2020
4589c0b
Fix UT
Feb 17, 2020
6118ae5
Print UT Debug
Feb 17, 2020
faeaf74
Add test logs
Feb 17, 2020
2bea883
Fix UT
Feb 17, 2020
b8eaafa
Fix compilation for VS 2015
Feb 17, 2020
bc55b6e
Merge remote-tracking branch 'origin/master' into improvement/fix-leaks
Feb 17, 2020
399e706
Execute tests for tags
Feb 17, 2020
4dfd155
Follow review comments
Feb 18, 2020
6b8fb25
Make find_package of ArrayFire explicitly use config files
Feb 19, 2020
278f5ee
Merge remote-tracking branch 'origin' into improvement/fix-leaks
Feb 19, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .CI/travis/build_linux.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,4 +26,4 @@ check-error "Error generating CMake configuration"
cmake --build . -- -j8
check-error "Error building Khiva"
ctest --output-on-failure
check-error "Error executing tests"
check-error "Error executing tests"
2 changes: 1 addition & 1 deletion bindings/jni/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
cmake_minimum_required(VERSION 3.9.6)

# Find the ArrayFire package.
find_package(ArrayFire REQUIRED)
find_package(ArrayFire CONFIG REQUIRED)
find_package(JNI)
if (NOT JNI_FOUND)
message(FATAL_ERROR "JDK not found. Please install JDK or disable building JNI bindings by using the flag KHIVA_BUILD_JNI_BINDINGS.")
Expand Down
2 changes: 1 addition & 1 deletion src/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ endif()
add_subdirectory(scamp)

# Find packages.
find_package(ArrayFire REQUIRED)
find_package(ArrayFire CONFIG REQUIRED)
find_package(Boost REQUIRED)
find_package(Eigen3 CONFIG REQUIRED)

Expand Down