Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Policy doesn't implement allows checks for all source directives #151

Closed
kingthorin opened this issue Oct 7, 2016 · 3 comments
Closed

Policy doesn't implement allows checks for all source directives #151

kingthorin opened this issue Oct 7, 2016 · 3 comments

Comments

@kingthorin
Copy link
Contributor

Policy.java needs allows checks added for font, media, object, default, etc directives.

Or were those purposefully excluded?
@kingthorin kingthorin mentioned this issue Oct 7, 2016
Closed
@shekyan
Copy link
Collaborator

shekyan commented Oct 7, 2016

We didn't have immediate need for those checks, so we prioritized implementing them low.
I'll try to implement them soon.

@kingthorin
Copy link
Contributor Author

Do you accept pull requests? I could probably knock that together later this weekend.

@shekyan
Copy link
Collaborator

shekyan commented Oct 7, 2016

Of course!

On Fri, Oct 7, 2016 at 1:06 PM, kingthorin notifications@github.com wrote:

Do you accept pull requests? I could probably knock that together later
this weekend.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#151 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABjjSXXBxuOSeVffrZTqFoEi4petJMn6ks5qxqY6gaJpZM4KQm-W
.

@kingthorin kingthorin mentioned this issue Oct 9, 2016
Merged
michaelficarra pushed a commit that referenced this issue Oct 12, 2016
@kingthorin @michaelficarra
Added Missing Allows Checks to Policy (#152)
890b989 
Policy.java now includes allowXFromSource() checks, where X is one of
the following:
font (font-src)
object (object-src)
media (media-src)
manifest (manifest-src)

This covers the remainder of the source directives that did not have
checks matching the existing functionality. Include additions to
PolicyQueryingTest.java.

Fixes #151
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@shekyan @kingthorin