fixes GH-161: Check if a policy is using strict-dynamic #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
introduces hasStrictDynamic, as well as modifying behaviour of `unsafe-inline`, hash-source, nonce-source querying functions to take into account presence of strict-dynamic keyword in the expression. strict-dynamic invalidates unsafe-inline for the scripts and has no effect for the styles.
michaelficarra
requested changes
Dec 7, 2016
| return this.hasUnsafeInlineScript() && !this.hasStrictDynamic(); | ||
| } | ||
|
|
||
| public boolean hasUnsafeInlineScript() { |
There was a problem hiding this comment.
Should probably be private.
| } | ||
| return styleSrcDirective.values().anyMatch(x -> x == KeywordSource.UnsafeInline); | ||
| } | ||
|
|
||
| public boolean allowsUnsafeInlineStyle() { | ||
| return this.hasUnsafeInlineStyle(); |
There was a problem hiding this comment.
Why does this indirection exist? Just rename hasUnsafeInlineStyle to allowsUnsafeInlineStyle.
| @@ -519,7 +539,7 @@ public boolean allowsScriptWithNonce(@Nonnull Base64Value nonce) { | |||
| } | |||
|
|
|||
| public boolean allowsStyleWithNonce(@Nonnull String nonce) { | |||
| if (this.allowsUnsafeInlineScript()) | |||
| if (this.allowsUnsafeInlineStyle()) | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
introduces hasStrictDynamic, as well as modifying behaviour of
unsafe-inline, hash-source, nonce-source querying functions totake into account presence of strict-dynamic keyword in the expression.
strict-dynamic invalidates unsafe-inline for the scripts and has no
effect for the styles.