Support 'report-sample' keyword-source #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shekyan
force-pushed
the
report-sample
branch
3 times, most recently
from
c84efaa to
0e2706a
Compare
| p = parseWithNotices("style-src 'report-sample' 'unsafe-hashed-attributes' 'report-sample' 'nonce-123'", notices); | ||
| assertEquals(1, p.getDirectives().size()); | ||
| assertEquals(2, notices.size()); | ||
| assertEquals("Invalid base64-value (should be multiple of 4 bytes: 3).", notices.get(0).message); |
There was a problem hiding this comment.
You have two notices and the one you're asserting on is unrelated to report-sample. Just fix the nonce and assert on the remaining notice.
There was a problem hiding this comment.
Both notices are unrelated to report-sample, removed the test
| p = parseWithNotices("script-src 'report-sample' 'report-sample'", notices); | ||
| assertEquals(1, p.getDirectives().size()); | ||
| assertEquals("script-src 'report-sample'", p.getDirectiveByType(ScriptSrcDirective.class).show()); | ||
| assertEquals(0, notices.size()); |
There was a problem hiding this comment.
Two report-samples, but no notices?
There was a problem hiding this comment.
Will be addressed in #185
michaelficarra
requested changes
Aug 10, 2017
michaelficarra
approved these changes
Aug 11, 2017
| @@ -391,6 +391,8 @@ private void enforceMissingDirectiveValue(@Nonnull Token directiveNameToken) thr | |||
| seenStates.add(SeenStates.SEEN_HOST_OR_SCHEME_SOURCE); | |||
| } else if (se == KeywordSource.UnsafeHashedAttributes) { | |||
| seenStates.add(SeenStates.SEEN_UNSAFE_HASHED_ATTR); | |||
| } else if (se == KeywordSource.ReportSample) { | |||
| seenStates.add(SeenStates.SEEN_REPORT_SAMPLE); | |||
There was a problem hiding this comment.
It seems silly to add this if it's not going to be read, but whatever.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #183