Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes #5: use random leaf nodes when depth limit is reached #6

Merged
merged 2 commits into from
Jun 13, 2016
Merged

fixes #5: use random leaf nodes when depth limit is reached #6

merged 2 commits into from
Jun 13, 2016

Conversation

michaelficarra
Copy link
Member

Fixes #5.

@michaelficarra
Copy link
Member Author

@bakkot This call stack is concerning. What was going on there?

@bakkot
Copy link
Member

bakkot commented Jun 13, 2016

@michaelficarra, given the call stack and the test which failed, it looks like a combination of two things: the RNG being used produced a cycle, and depth for arrow expressions with concise bodies isn't being increased.

@bakkot bakkot merged commit adabd31 into es2016 Jun 13, 2016
@bakkot bakkot deleted the GH-5 branch June 13, 2016 01:01
@michaelficarra
Copy link
Member Author

@bakkot Yeah, I noticed that, but couldn't figure out how the depth tests would still be passing in the presence of a bug like that. 😕

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@bakkot bakkot

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michaelficarra @bakkot