wip: solana native support #702
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 2009e84.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
gomesalexandre
commented
Dec 23, 2024
| @@ -57,5 +58,6 @@ | |||
| "bs58": "^4.0.1", | |||
| "cosmjs-types": "^0.4.1", | |||
| "msw": "^0.27.1" | |||
| } | |||
| }, | |||
| "gitHead": "a59c5a12b265b6f64c65920cf330358a250227c2" | |||
There was a problem hiding this comment.
revert before opening me
gomesalexandre
commented
Dec 23, 2024
| @@ -245,6 +255,7 @@ export class NativeHDWallet | |||
| #deviceId: string; | |||
| #initialized = false; | |||
| #masterKey: Promise<Isolation.Core.BIP32.Node> | undefined = undefined; | |||
| #ed25519MasterKey: Promise<Ed25519Node> | undefined = undefined; | |||
There was a problem hiding this comment.
since regular master key is a regular BIP32 node i.e seckp256k1 elliptic curve
gomesalexandre
force-pushed
the
feat_solana_native
branch
from
fd6fff2 to
5f7eb93
Compare
gomesalexandre
commented
Dec 23, 2024
| @@ -15,6 +15,7 @@ | |||
| }, | |||
| "dependencies": { | |||
| "@bitcoinerlab/secp256k1": "^1.1.1", | |||
| "@noble/curves": "^1.4.0", | |||
There was a problem hiding this comment.
note @noble/ed25519 is also available as a lightweight version but @noble/curves has more safety/features implemented
gomesalexandre
commented
Dec 23, 2024
Comment on lines
+53
to
+54
| // SLIP-0010 for Ed25519 | ||
| const data = Buffer.concat([Buffer.from([0x00]), Buffer.from(this.#privateKey), indexBuffer]); |
There was a problem hiding this comment.
That's the part we probably got wrong
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Includes:
Transaction signature verification failurebecause signing is using secp256k1 signature, which, even if you manage to sign with it, will be nope'd by the node)TODO:
Issue