revert: revert remove wallet connect page #8466
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR has been reverted because when someone clear cache on the wallet page, then try to connect to a native wallet, it loads indefinitely
This issue was always existing but appeared when we removed the connect wallet page
It seems there is a race condition somehow where deviceId is set but wallet is undefined, in order to avoid trying to find the root cause because the WalletProvider is a pita, I would prefer to wait for wallet to be defined
Also remove the connect wallet page dead code as it was initially done and tested
Issue (if applicable)
spotted in https://discord.com/channels/554694662431178782/1324583740000698420/1325624884415565844
Risk
Medium (related to market data and portfolio data loading along with wallet)
Testing
Engineering
n/a
Operations
n/a
Screenshots (if applicable)
https://jam.dev/c/eefa5a79-dff8-4ede-96a5-ae23beec5177