iOS tv-casting-app: cancelDiscoveryCommissionersWork should be dispatched on the chipWorkQueue (not clientQueue) #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ched on the chipWorkQueue (not clientQueue)
sharadb-amazon
requested review from
rawadhilal88,
cliffamzn and
domichae-amazon
rawadhilal88
approved these changes
Jun 28, 2023
domichae-amazon
approved these changes
Jun 28, 2023
chrisdecenzo
approved these changes
Jun 28, 2023
|
All PRs require an issue to be accepted, please link an issue or mention it in the body using #<issue_id> |
rawadhilal88
approved these changes
Jun 30, 2023
|
All PRs require an issue to be accepted, please link an issue or mention it in the body using #<issue_id> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
This commit 2d5f022 introduced a way to time the discovery process out on the iOS tv-casting-app. However, it dispatched the cancelDiscoveryCommissionersWork on the clientQueue. This is incorrect, as that is interacting with the CastingServer.
Additionally, the cancelDiscoveryCommissionersWork needs to be cleaned up (canceled, nil'ed) when stopMatterServer is called.
Solution
Initialized the chipWorkQueue earlier, in the CastingServerBridge.init(), and dispatched cancelDiscoveryCommissionersWork on the chipWorkQueue instead.
Testing
Tested with the iOS tv-casting-app