Adds the ability to define a custom status for a bot #235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarragon
reviewed
Sep 13, 2023
| @@ -548,7 +548,11 @@ def update_status(status, activity, url, since = 0, afk = false, activity_type = | |||
| @streamurl = url | |||
| type = url ? 1 : activity_type | |||
|
|
|||
| activity_obj = activity || url ? { 'name' => activity, 'url' => url, 'type' => type } : nil | |||
| activity_obj = if activity_type == 4 | |||
| { 'name' => activity, 'type' => type, 'state' => activity } | |||
There was a problem hiding this comment.
type here will (or should) always be 4. If something is changed in the logic above and type ends up not 4 then this might cause unwanted behaviour.
Setting 'type' => 4 or 'type' => activity_type might be better.
There was a problem hiding this comment.
The only problem I can see is that I used activity_type == 4 instead of type == 4 by mistake, which could have caused inconsistency in some cases.
But there's no reason to hard-code the value instead of using that of the variable, as long as it's the right one that's used and verified by the condition
I force push the change
|
Tested this locally and it worked as expected, looks good to me! |
Dakurei
force-pushed
the
custom_status
branch
from
0e75cf5 to
6659596
Compare
Possible for some time apparently (https://discord.com/developers/docs/change-log#aug-8-2023) However, a bot can only define customizable text, no emoji can be defined + Adds a test/example file for custom status display
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Possible for some time apparently (https://discord.com/developers/docs/change-log#aug-8-2023)
However, a bot can only define customizable text, no emoji can be defined (With the exception of putting a unicode emoji directly into the status text, only server emojis cannot be used in this way, of course 😎)
Added
Bot#custom_status=to set custom statusexamples/custom_status.rbChanged
Bot::update_statusto add custom status