-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow supressing embeds on Message #240
Allow supressing embeds on Message #240
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mainly looks good just needs a few minor changes. The main thing is that I'd say the pry-byebug
dependency isn't really needed and goes way beyond the scope of this PR.
4c23b70
to
d1544ff
Compare
We should be good to go now |
Almost there, I think you forgot to remove the dependency from the spec dependency though 😅 |
d1544ff
to
d8c3f3e
Compare
Derp, done |
d8c3f3e
to
77731ae
Compare
@Droid00000 well, this should be good now |
Looks great! It could be interesting to use this PR to further implement message flags (in a similar way to how the permissions class is currently structured). This is what I came up with: https://gist.github.com/wouterdedroog/59ed3076558c6d943dca5f8c75d5437f |
@Droid00000 bump |
Would you be open to doing the API portion through a message update rather than a dedicated API method? I don't want to add an API level method for every flag that may need to be updated. Just something like flags = @flags | SUPPRESS_EMBEDS
API::Channel.edit_message(..., flags) |
I most certainly don't mind, but I'd like to work on this incrementally. When this gets merged, then I'll prepare another PR |
@Droid00000 sorry if I'm annyoing but it would be nice to merge this so I can iterate on this |
🎊 I'll try whipping something up to address #240 (comment) this weekend |
I merged Droid's branch that has the feedback addressed using your branch as the base |
Summary
pry-byebug
to development dependenciesAPI::Channel#suppress_embeds
Message#suppress_embeds