chore: V4.0 fully remove user account methods #286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Separates out the removal of user account login related changes in the previous 4.0 commit into their own commit. I noticed a few other things related to user accounts, so I've attempted to deprecate them.
Removed
Discordrb::API.loginDiscordrb::API.logoutDiscordrb::Bot.process_tokenDiscordrb::API.validate_token— This used the old/auth/loginroute.Discordrb::API.acknowledge_message— This endpoint is not usable by bot accountstypeparameter on constructor for bot object. — Pointless to keep since only bot accounts are supported.OP: 5— The comments say that a bot should never send this OP code, and I can't find anything about in the docs. This seems to be something different than voice OP 5.Setting the status via the REST API is no longer supported so the following have been removed:
Discordrb::Profile.onlineDiscordrb::Profile.idleDiscordrb::Profile.dndDiscordrb::Profile.invisibleUpdated
Updated the way we process the bot token to reflect what you've done with the API client. (This allows use to remove the
process_tokenmethod)