Bugfix - Discordrb::Message#reacted_with

[y-bonfire]

Summary

I noticed this bug recently.
#60

Upon investigation, I realized that the issue stems from a misunderstanding of how proc works. Returning inside a proc causes it to return a value immediately, which prevents the loop from continuing. This appears to be a basic Ruby mistake.

After applying the fix, I ran the code locally and confirmed that it successfully retrieves users with more than 100 reactions.

Here is a simple sample to illustrate the issue.

def proc_return_test

  proc_test = proc do |a|
    return a
  end

  val = proc_test.call(1)
  puts val
  0
end

def proc_next_test

  proc_test = proc do |a|
    next a
  end

  val = proc_test.call(1)
  puts val
  0
end


# 1
puts proc_return_test

# 1,0
puts proc_next_test

[y-bonfire]

@swarley @Daniel-Worrall review please

[Daniel-Worrall]

@y-bonfire Was the code tested before the change as well? The code changed in the PR originates after the issue was posted, and the issue may not even still be applicable

[y-bonfire]

@y-bonfire Was the code tested before the change as well? The code changed in the PR originates after the issue was posted, and the issue may not even still be applicable

@Daniel-Worrall
Yes, I confirmed that for cases like 600 reactions, the code previously only retrieved 100. After the change, it now retrieves the expected values as intended.